Default methods aren't skipped

Interfaces can have default methods since Java 8. There was an attempted code fix to ignore them in the FactoryProvider: https://github.com/google/guice/commit/85f14e03ee00b20e20fd0f018a00ef52fcf909b1

However, the fix doesn’t work because the condition needs to be || instead of &&. (Default methods aren’t synthetic or bridge)

This makes it so that if you call any default method in an interface, you end up with the Guice-provided method instead of the default one.

public interface FooFactory {
    Foo create();

    default Foo createWithData(Data data){ 
        Foo foo = create();  // This will never be called, even if you call `fooFactory.createWithData(data)`
        foo.addData(data);
        return foo;
    }
}

[nathanmerrill]

You mention skipping non-bridge/synthetic default methods may be backwards incompatible: I’m struggling to come up with a use-case of somebody writing a default method, but wanting it to be overridden by Guice.

That said, assuming that there is a use-case, I think it would it be possible to use some annotation to indicate to “skip this method”? I’m not a huge fan of introducing an entirely new annotation for a small edge case as this, but I think it would work.

[badbob]

Is there are any progress on this issue?