Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Exceptions are swallowed when using withCompilation flag

See original GitHub issue

Hey, per title, when returnOkOnError=false && withCompilation=true I would expect to fail with calling AnalysisResult.compilationError instead of proceeding with the compilation.

Any reason we would not want to fail fast in that scenario?

Happy to submit a PR in case you agree with this case.

Issue Analytics

State:
Created a year ago
Reactions:3
Comments:6

Top GitHub Comments

1reaction

neetopiacommented, Aug 9, 2022

Thanks for the remind, added to next milestone for discussion.

0reactions

neetopiacommented, Aug 10, 2022

This actually looks like a bug to me after taking a deep look, basically the logic here ignores returnOkOnError when withCompilation is set to true. Current plan is to fix it rather than introducing a new flag.

Top Results From Across the Web

Swallowing exceptions flag to turn that off? #1910 - GitHub

Swallowing exceptions (and just logging and not monitoring it) is generally not a good practice since stuff gets unnnoticed.

"unhandled exceptions" a problem? - Ask TOM

My main problem with this approach is that it consists of "swallowing" exceptions and allows the host program to ignore the error (either...

Unhandled exception swallowed (except in debugger)

I'm maintaining a legacy C# Winform application, using .NET 4.0 framework. The application works fine, but occasionally due to bugs in the ...

Error and Transaction Handling in SQL Server Part Two

Note: With the exception of this section, the output for all examples in this ... BrownShoesDontMakeIt AS BEGIN TRY RAISERROR('This error is swallowed',...

Principles of Exception Handling | Struts Survival Guide

If you catch an exception, don't swallow it. Log an exception where you catch it, ... Principle 10 is about the use of...