question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Ensure environment map adheres to lazy loading semantics

See original GitHub issue

As of #487 , we will have introduced progress bars, the notion of loading progress and the notion of new reveal semantics. However, we still need to ensure that environment maps are not aggressively loaded if the user has appropriately configured <model-viewer> to indicate that they would rather defer loading the environment map until the last possible moment.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:16 (8 by maintainers)

github_iconTop GitHub Comments

1reaction
pushmatrixcommented, Nov 11, 2019

@elalish I don’t do anything fancy with perf testing. I just use the performance monitor in Chrome.

Here’s a glitch running master: https://sugary-bathroom.glitch.me/ Screen Shot 2019-11-11 at 11 15 32 AM

And then I compare it with one running 0.7.2: https://spurious-ringer.glitch.me/ Screen Shot 2019-11-11 at 11 17 41 AM

Probably lots of factors coming into play here, so the results do have a +/- 20ms to them.

1reaction
pushmatrixcommented, Nov 11, 2019

@elalish Tested the speed difference between 0.7.2 and master in terms of env map rendering, and it seems like it shaves off 40ms.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Progress bars by cdata · Pull Request #487 · google/model-viewer ...
A new progress event is introduced, maps directly to our internal notion of progress ... Ensure environment map adheres to lazy loading semantics...
Read more >
Grids Part 2: Semantics - Sarah Higley
A dive into table and grid semantics, why they matter so much to screen ... If you lazy-load columns as well as rows,...
Read more >
IROS 2022 Program | Monday October 24, 2022
Technical Program for Monday October 24, 2022 ; Chair: Ohara, Kenichi, Meijo University ; Co-Chair: Suzuki, Takuo, Aichi Prefectural University.
Read more >
IdroGEO: A Collaborative Web Mapping Application Based on ...
The IdroGEO architecture has been designed to ensure the principles of reuse, ... and the mechanism to cache lazy-loaded resources and application map...
Read more >
Shared-Environment Call-by-Need - UNM Digital Repository
Call-by-need semantics formalize the wisdom that work should be done at most ... The explicit environment sharing ensures that the closure.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found