Wall placement not working on Scene-Viewer mode

Description

Is enable_vertical_placement too much experimental? I’m currently using this with some objects on an intent without the need of model-viewer, but I realized the same problems occurs if I’m opening through the AR button on a model-viewer element. There’s an example on my glitch page, but basically the following does not work:

<model-viewer 
  src="https://cdn.glitch.com/36cb8393-65c6-408d-a538-055ada20431b/Astronaut.glb?1542147958948"
  ar
  ar-modes="scene-viewer"
  ar-placement="wall"
></model-viewer>

I know it’s not model-viewer related, but i feel like it’s the best place to ask for an issue about scene-viewer.

Live Demo

https://thirsty-befitting-trollius.glitch.me https://glitch.com/edit/#!/thirsty-befitting-trollius

Version

• model-viewer: v1.6.0

Browser Affected

• Chrome, version: 90.0.4430.66
• Edge
• Firefox
• IE
• Safari

OS

• Android
• iOS
• Linux
• MacOS
• Windows

AR

• WebXR
• SceneViewer
• QuickLook

[milesgreen]

Retesting with Google app v 12.19.11.29.arm64 Vertical placement looks fixed! ✅

I can now go into SceneViewer from ar_only , ar_preferred , or 3d_preferred (and then open in AR). No crashes. The model loads and can be placed in the scene.

It looks like, for vertical placement, SceneViewer is now only using the floor-placement with t-bar controls (not sure what else to call them)? The t-bar controls are super helpful for instances where walls have no detail to track to. But on detailed walls, it looks like it’s not attempting to place on the vertical plane. I thought it used to, and only fall back to t-bar mode if it couldn’t find enough detail in the vertical plane?

That said, once placed on a detailed wall, I can move right into it, without keeping the floor in view, and it keeps tracking to the detailed vertical plane. So that’s cool.

Thanks for the fix @timmmeh !

[ghost]

Ok I have another patch going in for this, as I said it looked like couple of different issues here, wasn’t sure which one was the most egregious so I focused on the vertical-placement first, but it turns out both issues would cause the same error but for different reasons.