question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add Feature Tour to Dashboard Sharing

See original GitHub issue

Feature Description

We should add a feature tour for the new Dashboard Sharing features, in line with what’s in the design doc/Figma mockups.

CleanShot 2022-06-08 at 20 34 13

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • A new feature tour for Dashboard Sharing should be added that includes a single overlay that highlights the new Dashboard Sharing button: https://www.figma.com/file/i04x83uA9U8HHBANlhS7Db/Dashboard-Sharing?node-id=737%3A17896
  • There should be a tour focused on the element/button that shows the Dashboard Sharing modal with the text:
    • New! Dashboard sharing in the heading
    • Share a view-only version of your dashboard with other WordPress roles in the body
    • Got it as the dismissal button

Implementation Brief

  • Create assets/js/feature-tours/dashboard-sharing.js which will contain the dashboard sharing feature tour.
  • Code can be copied over from assets/js/feature-tours/help-visibility.js with the following changes:
    • Replace helpVisibility by dashboardSharing
    • context should be VIEW_CONTEXT_DASHBOARD
    • version should be 1.85.0 (a version far in the future, see this comment: https://github.com/google/site-kit-wp/issues/5328#issuecomment-1154442987)
      • Add a TODO item noting this version should be changed when the feature flag is removed to the actual upcoming version when the flag is removed.
    • gaEventCategory should be ${ viewContext }_dashboard-sharing [TBD]
    • The steps array should contain only one item with the following details:
      • target should be .googlesitekit-sharing-settings__button
      • title and content as per the AC.
      • placement should be bottom-start
    • Add checkRequirements which should be a function that checks whether the dashboardSharing feature flag is enabled, via the isFeatureEnabled function.
  • Update assets/js/feature-tours/index.js to include the new feature tour.

Test Coverage

  • No new tests to be added.

QA Brief

  • QAing this would require going to the Site Kit Dashboard and making sure a feature tour tooltip appears targeting the Dashboard Sharing settings button which includes the text mentioned in the AC.
  • The dashboardSharing feature flag needs to be turned on in the tester plugin for this to show up.
  • Note that the UI can be a little different than the actual Figma design to keep it consistent with the other feature tours. Sometimes the Figma designs are out of sync with our code base. As a result, the difference is expected.

Changelog entry

  • Add a feature tour for the dashboard sharing.

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:8

github_iconTop GitHub Comments

1reaction
aaemnnosttvcommented, Jun 15, 2022

Great thanks!

Regarding the tour, we discussed extending this with additional steps earlier today that would include the sharing settings. I’ll open a new issue for investigation as a potential follow-up to this one.

IB ✅

1reaction
tofumattcommented, Jun 15, 2022

Oh, right on, makes sense.

Cool, I’ve put a far-future version in there for now and added a note about the reasoning/comment 👍🏻

I figured 1.85.0 was fine, but if it should be adjusted in either direction and the IB’s otherwise fine feel free to do that 🙂

Read more comments on GitHub >

github_iconTop Results From Across the Web

Share a responsive dashboard
Share a responsive dashboard · Navigate to All > Self-Service > Dashboards or All > Performance Analytics > Dashboards. · Use the Search...
Read more >
Dashboard Sharing - Pendo Help Center
Share with individual users · 1. Click Sharing with people to open the user sharing menu. SharingWithPeople. · 2. Search for a user...
Read more >
Create a Dashboard to Organize and Share Research
Your browser can't play this video. Learn more. Switch camera.
Read more >
Step 6: Sharing & Administering CX Dashboards - Qualtrics
Adding Dashboard Users ... It's time to head back to the dashboard project to check out the User Admin tab. This is where...
Read more >
User tours - MoodleDocs
How do I add steps to a tour ? · Block - to display next to a matching block on the page. Select...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found