Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Avoid showing administration-related banner notifications in view-only dashboard

See original GitHub issue

Bug Description

The view-only dashboard is currently showing banner notifications related to administration, which should not be shown in such a case of course, since the user can’t act on them. See the below screenshot which shows the Idea Hub CTA banner notification to a contributor user.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

From all banner notifications part of BannerNotifications or EntityBannerNotifications, the only notification(s) that should ever be shown in a view-only context should be ZeroDataStateNotifications.

Implementation Brief

In the BannerNotifications component:
- Rely on useViewOnly (e.g. const viewOnly = useViewOnly()).
- Wrap all notifications within the rendered Fragment in a check whether ! viewOnly, except for ZeroDataStateNotifications.
EntityBannerNotifications can remain unchanged since it only contains ZeroDataStateNotifications anyway.

Test Coverage

No new tests needed.

QA Brief

Ensure that only zero-data state notifications display when viewing the view-only Dashboard.
Ensure that all types of notification continue to display on the authenticated Dashboard.

Changelog entry

Prevent admin-related notifications from appearing on view-only dashboard.

Issue Analytics

State:
Created a year ago
Comments:7 (1 by maintainers)

Top GitHub Comments

1reaction

techanvilcommented, May 31, 2022

Hi @wpdarren, thanks for pointing this out - in hindsight the issue could have been a bit clearer. Gathering data notifications are also relevant to non-admin users and are included in the ZeroDataStateNotifications component mentioned in the AC. So, they should still continue to be seen.

0reactions

wpdarrencommented, May 31, 2022

QA Update: ✅

Verified:

Only zero-data state notifications display when viewing the view-only Dashboard.
All types of notification continue to display on the authenticated Dashboard.

Screenshots

Top Results From Across the Web

Disable the Salesforce Notification Banner

Easily remove the Salesforce Notification Banner for all users in your organization.Required Editions and User Permissions Available in: both Salesforce C..

Notifications - System experiences - Human Interface Guidelines

A notification gives people timely, high-value information they can understand at a glance.

Create an Advisory Dashboard - VMware Docs

From the top navigation bar, select Administration. · In the left panel, under Settings, select Advisories and click New. · In the description...

Manage notifications for a team, project, or organization

Open your User settings, and then select Notification settings from the resulting list. Go to personal notifications, current page. · To ...

Global Banner Notifications - HPE Design System

Global Banner Notifications are system generated alerts that attract user's attention to system ... Only show one banner at a time. ... Things...