Change Analytics setup description

Related to #4913 and #5045, some of the descriptive text in the Analytics setup flow should be simplified as it is now replaced with the new toggles displayed there.

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Relying on the feature/existing-tag-simplification branch:

• The Analytics ExistingTagNotice should be simplified to only keep the information around GTM tags, but no longer inform about “existing” tags, as these are covered via #4913 and #5045 now.
  • In other words, the only check that should remain in the component is hasGTMAnalyticsProperty, and then it should display the notice from getNoticeForExistingGTMProperty().
• Throughout all scenarios of the Analytics setup flow, the following minor copy adjustment should be made:
  • Please select the account information below. You can change this view later in your settings. --> Please select the account information below. You can change this later in your settings.

Implementation Brief

Any PR for this must be based on and target the feature/existing-tag-simplification branch.

• Using assets/js/modules/analytics/components/common/ExistingTagNotice.js,
  • Keep only the check for hasGTMAnalyticsProperty and all the logic associated to it. This means removing the following:
    • getNoticeForExistingUAAndGA4Tags
    • getNoticeForExistingUATag
    • getNoticeForExistingGA4Tag
• Using the files below, update the text as per the second bullet point of the AC.
  • assets/js/modules/analytics/components/setup/SetupFormGA4.js
  • assets/js/modules/analytics/components/setup/SetupFormGA4Transitional.js
  • assets/js/modules/analytics/components/setup/SetupFormLegacy.js
  • assets/js/modules/analytics/components/setup/SetupFormUA.js

Test Coverage

• No new tests to be added.

QA Brief

• GTM Notices will be shown in the top of the Setup and Settings page when relevant.
• Existing Tag Notice for UA and GA4 will be shown on their respective toggles in Setup page.
• Existing Tag Notice will continue to surface on top of Settings View and Settings Edit page.
• The Updated Copy from the AC will be shown on all relevant places.

Changelog entry

• N/A

[kuasha420]

@felixarntz I have updated the QA brief. Cheers.

[kuasha420]

There is a big slack discussion on the problem that @wpdarren found. I’m here documenting what went wrong and where we are now regarding this. Also what needs to be done to potentially resolve this issue.

What happened?

• We used to have separate ExistingGTMPropertyNotice and ExistingTagNotice before ETS.
• We merged them together in #4703
  • At that point, if there was both GTM and UA tag, the message for UA would take precedence and shown.
• In #4913 and #5045 we added Snippet toggle to the Setup flow of the Analytics(UA and GA4). We also copied the messaging related to Existing Tag below the toggle.
  • Note that, this existing tag related messages are only shown under Snippet Toggles in Setup flow. Settings is not changed.
  • At this point, the setup flow is showing two similar existing tag notices in Setup flow - one above the form and one under the toggles.
• With this issue, we tried to take care of the duplicate Existing Tag messages by removing them from the top of the Setup screen by removing them from the ExistingTagNotice component.
  • This solves the duplicate message problem in Setup flow.
  • However, as we haven’t implemented Existing Tag messages in the Snippet Toggle for Settings page, the Settings View and Settings Edit screens no longer has any notices related to Existing Tag.

Solution

• Re-purpose current ExistingTagNotice as the ExistingGTMPropertyNotice which will be used directly on top of Setup Form.
• Restore old combined (GTM and ET) ExistingTagNotice as the notice that will be shown on Settings(View/Edit) screens. We can refactor it to use ExistingGTMPropertyNotice when there is no UA and there is GTM.

Caveats Copies need to be checked and confirmed/corrected.

@felixarntz I’m assigning this back to you. Please review my finding and proposed solution and let me know how to move forward. Cheers.