Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Clarify "All admins" wording in Dashboard Sharing settings

See original GitHub issue

Feature Description

In the “Who can manage view access” section of Dashboard Sharing settings, the wording “All admins” needs more clarification. It is easily misread as “All WordPress admins” but it really means “All WordPress Admins who have authenticated with Site Kit + their Google Account”. We should clarify this wording to avoid confusion.

The wording in question:

CleanShot 2022-06-16 at 16 37 22

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

The wording in the “Who can manage view access” dropdown should be updated from “All admins” to “Any admin signed in with Site Kit”

Implementation Brief

Update https://github.com/google/site-kit-wp/blob/26304ca85a87770a1e837f904cf983ea4d8040dd/assets/js/components/dashboard-sharing/DashboardSharingSettings/Module.js#L68 to “Any admin signed in with Site Kit”

Test Coverage

No news tests needed.

QA Brief

Make sure the dashboardSharing feature flag is enabled.
Make sure there is more than one admin in the site (otherwise the “Who can manage view access” column will not show up).
Go to Google Site Kit Dashboard.
Open the Dashboard Sharing settings modal.
Make sure the “All Admins” option now says “Any admin signed in with Google”.

Changelog entry

Clarify “All admins” wording in Dashboard Sharing settings.

Issue Analytics

State:
Created a year ago
Comments:6

Top GitHub Comments

2reactions

techanvilcommented, Jun 21, 2022

The current PR attached to this issue is set to replace “All Admins” with “Any admin signed in with Google” according to the above discussion. I’m happy to change it if we decide otherwise.

While we’re on the discussion about copy, @aaemnnosttv @tofumatt Do you think it is necessary to capitalise (capital for the first letter of every word) this sentence like it was before (“All Admins”) and the other option (“Only Me”) for consistency?

Hi @nfmohit, I don’t think we should capitalise this sentence, as we don’t generally capitalise sentences like this, only phrases/titles, generally of 2-4 words.

However you raise a good point about consistency. I think we should instead update the casing of “Only Me” to be “Only me”, for consistency here.

1reaction

aaemnnosttvcommented, Jun 16, 2022

@tofumatt @felixarntz would it be more clear if we said “any admin signed-in with Google” rather than with “Site Kit”? I feel the latter may be a bit easier to misinterpret.

Thoughts @bethanylang ?

Top Results From Across the Web

User Permissions for Sharing Reports and Dashboards

Create, edit, and delete dashboards, 1 and manage their sharing in all public dashboard folders. This permission does not extend to others' personal...

Give view access to DashBoards in Salesforce

(For non public folder dashboards) Go to that dashboard stored dashboard Folder >> Click Share option then you can mention the user /...

Configuring Explore dashboard sharing permissions

To configure dashboard sharing permissions In Explore, open the Admin menu ( ) on the left panel, then select Dashboard sharing permissions (...

Basic concepts for designers in the Power BI service

In this article. Power BI concepts; Capacities; Workspaces; Dataflows; Datasets; Reports; Dashboards; Workbooks; A dashboard in My Workspace ...

Sites Overview - Tableau Help

A server administrator can assign one of the Site Administrator site roles to users to delegate creating and maintaining a specific site's user...