question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Clarify wording of permissions modal when creating a web data stream

See original GitHub issue

Feature Description

When setting up Analytics with GA4, if the selected GA4 property does not have an associated web data stream, or does not have one that matches the URL of the WP site then Site Kit will automatically create one. This happens automatically when creating a GA4 property as well, but since the two actions require the same scopes, the user only sees the prompt for creating a new property and is not prompted again for the creation of the web data stream.

However, if a user was to select a different GA4 property after different scopes had been granted that did not include the on-demand analytics.edit scope, then the web data stream would still be created automatically (again assuming one did not exist with a matching URL) which would then prompt the user for permissions to create it. This could be a confusing experience for the user because Site Kit has no language around web data streams at all – we only show the measurement ID in the settings screen.

The language for the on-demand request for scopes for creating a web data stream should be updated to use consistent language to reference a measurement ID instead (exact wording TBD).


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The datapoint definition for POST:create-webdatastream’s message should be updated to be the following:

You’ll need to grant Site Kit permission to create a new Analytics 4 Measurement ID for this site on your behalf.

Implementation Brief

  • Update the request_scopes_message of the POST:create-webdatastream definition to be:
    You'll need to grant Site Kit permission to create a new Analytics 4 Measurement ID for this site on your behalf.
    

Test Coverage

  • N/A

Visual Regression Changes

  • N/A

QA Brief

To see the permissions modal

  1. Reset your Site Kit plugin
  2. Connect the plugin again
  3. Activate the Analytics module
  4. On the Analytics setup form, select an account that has a UA property and GA4 property without a web data stream.
  5. Submit the setup form.
  6. You should see the permissions modal with the new text from theAC

Changelog entry

  • Update wording in permissions modal when GA4 needs to create a web data stream for the selected property.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:9 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
eugene-manuilovcommented, Jul 6, 2021

@danielgent try to do the following:

  1. Reset your Site Kit plugin
  2. Connect the plugin again
  3. Activate the Analytics module
  4. On the Analytics setup form, select an account that has a UA property and GA4 property without web data stream.
  5. Submit the setup form.
  6. You should see the permissions modal.
1reaction
aaemnnosttvcommented, Jun 28, 2021

@tofumatt in this case, I think future tense is more correct because the user is about to be prompted to grant permissions. If we say they need to do it (now) it may be confusing that there is some action they need to take before they can proceed, which would arguably be more confusing since they need to proceed to grant the permissions. This is also consistent with the existing language in the other datapoint scope messages as well as account provisioning: image https://github.com/google/site-kit-wp/blob/37e9cad8e29c8fa83bd8337bf9403f80243d42a4/assets/js/modules/analytics/components/common/AccountCreate/index.js#L189-L190

If we do want to reconsider the language around these prompts, let’s revisit that in a dedicated issue since this is different than what was done previously regarding module settings/selections. Also see https://github.com/google/site-kit-wp/issues/3623

TL;DR let’s keep the original wording for now and then I think this can move forward since the original IB was already consistent with that.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Accessing private data - Patterns - Human Interface Guidelines
Request permission only when your app clearly needs access to the data or resource. It's natural for people to be suspicious of a...
Read more >
Handling Trust and Permissions in Web Applications - W3C
Each application includes a manifest with a declaration of the permissions that the app needs. Users are required to give their consent before...
Read more >
3 Design Considerations for Effective Mobile-App Permission ...
Explain why the app requires access and convey the user benefits. Generally, a good content formula for permission requests goes like this: [app] ......
Read more >
Using modals in Slack apps
Publishing messages after modal submissions​​ You have three options for doing so: Request necessary permissions and use the Web API, Generate and use...
Read more >
Permissions on Android - Android Developers
Overview · Use Stream Protect for latency-sensitive streaming apps. Build TV input services. Overview · Develop a TV input service · Work with...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found