GA4 settings persist after Analytics is deactivated

Bug Description

When disconnecting a module, its settings are always deleted by the Module::on_deactivation method. However, due to some ga4-specific implementation details, this doesn’t happen for GA4.

Steps to reproduce

1. Enable ga4setup
2. Setup Analytics with a GA4 property
3. Deactivate the Analytics module
4. Go to /wp-admin/options.php
5. See googlesitekit_analytics-4_settings is still present. Alternatively, with wp-cli you could use wp option get googlesitekit_analytics-4_settings

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• When ga4setup is enabled, the GA4 module should be deactivated when Analytics is deactivated

Implementation Brief

• Merge #3624

Test Coverage

• N/A

Visual Regression Changes

• N/A

QA Brief

• Activate the Analytics module and select an account with both UA and GA4 properties on the setup form.
• Go to the Analytics settings and make sure that you see GA4 property in the settings view.
• Disconnect the Analytics module.
• Verify that the following commands return empty settings for analytics and analytics-4:

  wp option get googlesitekit_analytics_settings
  wp option get googlesitekit_analytics-4_settings
  

Changelog entry

• Fix a bug where GA4 settings were not cleared when deactivating Analytics.

[Hazlitte]

@aaemnnosttv Oops, yes you are right. I meant the settings values in the options table. 🤦‍♂️

[eugene-manuilov]

Sounds good to me, @aaemnnosttv. Let’s go with your branch then. Could you please create a PR for your branch and update the IB?