Idea Hub post annotation only shown on drafts

Bug Description

When you trash a draft post, the idea isn’t shown in the trash.

Steps to reproduce

1. Create a draft from an idea, notice the idea name is in the status.
2. Trash the post, idea name is not shown.
3. Restore the trashed post, and see the idea is shown again.

Recording

https://user-images.githubusercontent.com/373931/130031511-4fe045a8-c7f4-4f7a-a4dc-d3ac43fadcb7.mp4

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• The Idea Hub annotation added to Idea Hub created posts in the post list table should be shown for posts of all statuses, not only drafts (e.g. trashed, future, pending, private, etc) – how it is added depends on the post status, post state, and post title
• For draft posts with no title only, the state should be replaced by Idea Hub Draft “{idea-name}”
• For all other post statuses OR drafts that have titles, the annotation should be simplified to inspired by Idea Hub
• For all post statuses (except drafts with no title)
  • If there is already content for the post state (e.g. scheduled), combine the original content of the post state by appending the annotation like so: {post-state}, {idea-hub-annotation}
  • If no content exists for the post state, the annotation becomes the post state, rather than appending to it
• See https://github.com/google/site-kit-wp/pull/4061#discussion_r712384583 for reference

Implementation Brief

• In includes/Modules/Idea_Hub.php -> register_persistent() -> display_post_states():

• 1. Remove the check for post status: https://github.com/google/site-kit-wp/blob/38ae6cb09c82acea56a5bde768028d93b3cc6580/includes/Modules/Idea_Hub.php#L165-L167
• 1. Instead of adding our message to the draft post state, add it for the current post’s post state https://github.com/google/site-kit-wp/blob/38ae6cb09c82acea56a5bde768028d93b3cc6580/includes/Modules/Idea_Hub.php#L173

$post_states[$post->post_status ] = ... 

• 1. If the post_title is empty "" === $post->post_title, use the current message sprintf( __( 'Idea Hub Draft “%s”', 'google-site-kit' ), $idea['text'] );, otherwise if a title is set, set the message to inspired by Idea Hub: https://github.com/google/site-kit-wp/blob/38ae6cb09c82acea56a5bde768028d93b3cc6580/includes/Modules/Idea_Hub.php#L173

Test Coverage

• Update test name and test in tests/phpunit/integration/Modules/Idea_HubTest.php::test_draft_labels()

https://github.com/google/site-kit-wp/blob/38ae6cb09c82acea56a5bde768028d93b3cc6580/tests/phpunit/integration/Modules/Idea_HubTest.php#L97-L147

Visual Regression Changes

• N/A

QA Brief

• Create an idea hub draft, ensure that the posts list table shows its status message as Idea Hub Draft ....
• Set a title and update the draft, ensure that the status says inspired by Idea Hub.
• Trash the post and ensure it still has the correct status message.

Changelog entry

• Update the post state for Idea Hub posts and enable it for posts of all statuses.

[marrrmarrr]

SGTM for using “inspired by Idea Hub” for all posts with a title updated by the user (including posts in draft state with an updated title).

[marrrmarrr]

@eugene-manuilov I’m not sure how familiar users will be in the beginning with the Idea Hub icon, and if they would understand why it’s there / what it means. I’d suggest adding the short text for now and revisit to add the icon at a later stage, a few months after we’ve rolled the feature out to 100% of eligible sites.