Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

IdeaHub: Draft Created Message Shows on Drafts Tab Briefly

See original GitHub issue

Bug Description

The draft created message from new tab is also shown on the drafts tab if we switch there fast enough.

Steps to reproduce

In new tab, create a draft.
Switch to drafts tab quickly
Notice that it says Draft Created before changing to View Draft

https://user-images.githubusercontent.com/373931/129885002-52251398-299c-4977-85af-da85d36fba1f.mp4

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

The timeout on the “Draft created” message in the Idea Hub widget (after successfully creating a draft) should be immediately stopped/cleared if the user navigates to another tab in the widget. It basically should be ensured that this contextual hint is no longer visible once seeing the same idea in another tab (realistically the “Drafts” tab, since that’s where such an idea would land then).

Implementation Brief

Using assets/js/modules/idea-hub/datastore/idea-state.js, add a new action removeActivities which has a mandatory parameter, activityType.
removeActivities should remove any item in the activities state variable which has the same value as activityType parameter.
Using assets/js/modules/idea-hub/components/dashboard/DashboardIdeasWidget/index.js, dispatch the removeActivities action within the handleTabUpdate passing IDEA_HUB_ACTIVITY_CREATING_DRAFT as value for the activityType parameter.

Test Coverage

Add tests for the newly added action.

Visual Regression Changes

QA Brief

Follow the repro steps and ensure you can no longer see Creating draft / Draft created messages in the Drafts tab

Changelog entry

Update the IdeaHub widget to not display “Draft created” message on the draft tab.

Issue Analytics

State:
Created 2 years ago
Comments:11 (3 by maintainers)

Top GitHub Comments

1reaction

ivankruchkoffcommented, Dec 8, 2021

@eugene-manuilov I don’t like the idea of putting presentation logic in an action.

I went down the path of not showing DRAFT_CREATED in the drafts tab, with the following commit: https://github.com/google/site-kit-wp/pull/4412/commits/d9d448d685e43ea6d562a63e98e4d5b318702105

Which gives us the following experience:

https://user-images.githubusercontent.com/373931/145134707-3984ecc6-9170-4198-a4f8-35dd53a06417.mp4

Which still allows for the temporary messaging on the New tab when we switch back to it within the two seconds.

0reactions

wpdarrencommented, Dec 9, 2021

QA Update: ✅

Verified:

When following the steps you can no longer see Creating draft Draft created messages in the Drafts tab.
Tested this on desktop and mobile, and the behaviour was the same.

https://user-images.githubusercontent.com/73545194/145410277-5bcbde7e-0cfa-46a0-a9e7-0a4713fadfbd.mp4