Implement the Success Component design
See original GitHub issueFeature Description
Implement the design for the Success Component - this is essentially just a message with a “Learn more” link.
- Design Doc: https://docs.google.com/document/d/1DeWo38lcV7lvLFfcmt-mQ0iaxzB4qfiPArs_yZzYkIM/edit#heading=h.3ufiycwdh8xj
- Figma: https://www.figma.com/file/vMaCWwr6lpk4PrJWb7jIpz/GA4-Banner-Input?node-id=1082%3A1553
Acceptance criteria
- The placeholder version of the Success Component (see #5270) should be replaced with the fully realised design. For reference, see Figma.
- Display the following text:
- Title: You successfully set up your Google Analytics 4 property
- Subtitle: GA4 is collecting data for your site. You’ll only see Universal Analytics data on your dashboard for now.
- Learn more link:
- Text: Learn more about GA4
- Link URL:
{proxy}/support/?doc=ga4- Note, this should be the URL returned by
select( CORE_SITE ).getDocumentationLinkURL( 'ga4' ).
- Note, this should be the URL returned by
Implementation Brief
- In
assets/js/modules/analytics-4/components/dashboard/ActivationBanner/SuccessBanner.js(being created in #5270):- Locate the
BannerNotificationcomponent. Within this component, add/update the following props:title:You successfully set up your Google Analytics 4 property(translatable).description:GA4 is collecting data for your site. You’ll only see Universal Analytics data on your dashboard for now.(translatable).WinImageSVG: should contain theSuccessGreenSVGsvg component.dismiss:OK, Got it!(translatable).format:smaller.type:win-success.learnMoreLabel:Learn more about GA4(translatable).learnMoreURL: Result ofselect( CORE_SITE ).getDocumentationLinkURL( 'ga4' )
- Locate the
Test Coverage
- Verify the storybook story for this step.
- Update VRT images if required.
QA Brief
- Visit Storybook and Check the ActivationBanner.
- In the story, newly added graphics and learn more link should appear.
- The learn more link should point to the one defined in the AC.
Changelog entry
- Implement the design for the Success component from the Analytics-4 module.
Issue Analytics
- State:
- Created a year ago
- Comments:8
Top Results From Across the Web
Design System: How to Effectively Create & Implement
The next key characteristic necessary for a successful design system implementation process is that it be comprehensive.
Read more >How To Measure the Success of Your Design System
Use These Metrics to Measure the Success of Your Design System · 1. Team Adoption · 2. Task Completion · 3. Design-to-Development Handoff...
Read more >The 3 Components of a Successful Systems Design
In successful systems design, three main components must be considered and managed effectively. These are quality, timeliness and ...
Read more >The designer's guide to design system ROI & success
A successful enterprise design system delivers cohesive, scaleable features in a way that's efficient for both design and development.
Read more >Writing a Successful Component Design and ... - TopCoder
helps the designers to understand how the component will be implemented. #4 Present Properly. A component specification is not just a collection ...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found

@nfmohit this IB looks good, the component path will likely need updating - see https://github.com/google/site-kit-wp/issues/5270#issuecomment-1196522807 - that aside this looks good to go!
The updated path will probably be:
assets/js/modules/analytics-4/components/dashboard/ActivationBanner/Success.js@mohitwp looks like the stories were restructured the same time this was being worked on to be more separate on https://github.com/google/site-kit-wp/pull/5645/files and @nfmohit worked on it. I’ll create a follow up PR to add now missing Success Component story and update the QAB accordingly. Cheers.