question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Remove userFeedback feature flag

See original GitHub issue

Since the feature is fully rolled out, we should remove the userFeedback feature flag.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The userFeedback feature flag should be removed
  • All code that has been activated when the userFeedback feature flag is enabled should work unconditionally now.
  • All code that has been deactivated when the userFeedback feature flag is enabled should be removed.

Implementation Brief

  • Update feature-flags.json to remove userFeedback
  • Search for the userFeedback string within the code base and review code where the userFeedback is present. Any logic/component which was rendered conditionally when the userFeedback feature was enabled should be rendered unconditionally now. Any code which was rendered when the feature flag was disabled should be removed.
  • Use of the useFeature hook with userFeedback as a parameter should be removed.

Test Coverage

  • No new tests to be added

Visual Regression Changes

  • N/A

QA Brief

  • Verify that the userFeedback feature flag no longer exists (e.g. it no longer shows up in the Site Kit tester plugin).
  • Verify that the user feedback functionality (specifically the rating survey) now shows up generally, i.e. without requiring a feature flag to be enabled.

Changelog entry

  • N/A

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:5 (1 by maintainers)

github_iconTop GitHub Comments

1reaction
aaemnnosttvcommented, Aug 25, 2021

Thanks for the PR @Patil2099! Normally it’s difficult for us to accept PRs from the community but in this case the changes are so small and ready to go that we should be able to use it 👍

0reactions
wpdarrencommented, Sep 2, 2021

QA Update: ✅

Verified:

  • Verified that the userFeedback feature flag no longer exists in the Site Kit tester plugin.
  • Verified that the user feedback functionality now shows up generally (used code provided to paste into console)

image

Read more comments on GitHub >

github_iconTop Results From Across the Web

Release Management Best Practices with Feature Flags
Collect user feedback and make changes if you need to. ... Once 100% of users have access to the feature, remove the flag....
Read more >
How to Manage Outdated Feature Flags - Optimizely
Not cleaning up feature flags can introduce risk to your code base. Learn how Feature Flag Removal Day can lead to better feature...
Read more >
Product Manager's Guide to Using Feature Flags in Release ...
Feature flags are also called config flags, feature toggles, flippers, ... You can simply disable the problematic feature and make sure it ...
Read more >
A Developer's Guide to Feature Flags
This system will result in deployments that simply remove feature flags, causing certain features to become standard in the codebase. Release flags will...
Read more >
15 Tips For a Smooth Feature Flag Rollout in 2019 - Split
The quick turnaround of a CI/CD (Continuous Integration/Continuous Delivery) model means that user feedback can be quickly processed to measure ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found