question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Scaffold SwG module

See original GitHub issue

This is a tracking issue for scaffolding out the SwG module foundation - essentially putting together all the “uncontroversial” pieces about adding a new module which don’t require much further design consideration since they rely on established infrastructure.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • There should be a new module subscribe-with-google.
  • It should be entirely hidden behind an swgModule feature flag.
  • The module info should be as follows:
    • Title: Subscribe with Google
    • Description: Generate revenue through your content by adding subscriptions or contributions to your publication
    • Order: 7
    • Homepage: _https://publishercenter.google.com/_
  • It should have a settings implementation with ownership concept and the following settings:
    • publicationID: The publication ID to use.
    • products: The list of products available.
    • Both of these settings should affect module ownership.
  • It should come with a JS file assets/js/googlesitekit-modules-subscribe-with-google.js which registers the module and its datastore in JS.
    • The datastore should for now be just a base module store with support for the two settings.

Implementation Brief

  • Complete #3120.
  • Specifically, introduce the swgModule feature flag and make sure the module is only loaded when that feature flag is enabled.

Test Coverage

  • Add test coverage for the module class and dynamic JS components.
  • Add Storybook coverage for the module setup UI and the module settings panel.

Visual Regression Changes

  • N/A

QA Brief

  • Enable the swgModule feature flag with the tester plugin
  • Click “Set up Subscribe with Google” on the Settings > Connect More Services page
  • Fill out the form, then click “Configure Subscribe with Google”
    • The Publication ID field expects a domain, such as example.com
    • The Products field expects a list of product names, one per line
    • You should see a congratulations message after submitting the form
  • Edit the Subscribe with Google plugin’s settings
    • You should be able to update the Publication ID and Products fields

Changelog entry

  • Scaffold Subscribe with Google module.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:8 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
cole10upcommented, Sep 13, 2021

Thanks @ChrisAntaki!

@felixarntz, I ran another test with the latest develop and I see the Dashboard Visitor Widget error again. I can follow up on a separate ticket for this issue. Otherwise I think it’s safe to push this to approval.

Site Kit by Google Settings ‹ SupremeQA — WordPress (1)

0reactions
ChrisAntakicommented, Sep 13, 2021

Hey @cole10up , here’s the issue for improving the validation #4025

Read more comments on GitHub >

github_iconTop Results From Across the Web

Scaffold | npm.io
A command-line interface for a quick and easy way to organize your scss. Generate an scss folder structure anywhere you want in your...
Read more >
PRO40 Is a Scaffold Protein of the Cell Wall Integrity ... - PLOS
The sum of our results implies that PRO40 is a scaffold protein for the CWI pathway, linking the MAPK module to the upstream...
Read more >
fabianstarke - npm
@4geit/ngx-material-module ... Scaffold the code base of an angular reusable module, component or service. ... @4geit/swg-get-user-with-credentials-helper.
Read more >
Chapter 10. Advanced Yeoman generators - liveBook · Manning
So far you've created a good setup to scaffold new projects. ... You can use sub-generators to add new modules to your project...
Read more >
PRO40 Is a Scaffold Protein of the Cell Wall Integrity ... - NCBI
However, the regulation of these modules by adapters or scaffolds is ... 7 consecutive days in race tubes on synthetic SWG medium ±...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found