Show errors instead of infinite loading state in AdSense V2 setup flow

Bug Description

In case of API errors, the V2 setup currently remains in an infinite loading state instead of showing the error to the user.

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• The AdSense V2 SetupMain component should be adjusted to show any relevant errors: Similar to the V1 version of the component, if there are any AdSense API errors (via hasErrors selector), it should show the errors via the AdSense ErrorNotices component.
  • In such cases, only that component should be shown instead of the regular SetupCreateAccount, SetupSelectAccount, or SetupAccount.
• The AdSense ErrorNotices component should be slightly adjusted: If the adsenseSetupV2 feature flag is active, it shouldn’t call the errorToStatus utility function to decide whether an error should show. Any error should show in the V2 flow.

Implementation Brief

SetupMain component

Within file assets/js/modules/adsense/components/setup/v2/SetupMain.js:

• Check for AdSense errors via the MODULES_ADSENSE store’s hasErrors selector, which returns a boolean.
• Update the if/else sequence which determines viewComponent to first check the result of hasErrors and set viewComponent to <ErrorNotices /> if so, as seen in the V1 SetupMain component: https://github.com/google/site-kit-wp/blob/64e9b6c7f7576d33b23f7105a1e4311c0fa40b4a/assets/js/modules/adsense/components/setup/SetupMain.js#L458

ErrorNotices component

Within file assets/js/modules/adsense/components/common/ErrorNotices.js:

• Use the useFeature hook to check whether the adsenseSetupV2 feature flag is enabled.
• Update the rendered StoreErrorNotices component, passing undefined for the shouldDisplayError prop if the feature flag is enabled, otherwise continue to pass the shouldDisplayError callback.

Storybook

• Add a new story for V2 SetupMain displaying the error state.

Test Coverage

• No new tests needed.

QA Brief

• Ensure the Adsense Setup V2 Error Notice story displays the error instead of the loading state. Story URL path - /story/modules-adsense-components-setup-v2-setupmain--error-notice
• Currently, we can’t test the error notice scenario using the tester plugin. Refer to this comment.

Changelog entry

• Update the AdSense SetupMain component to show existing errors.

[felixarntz]

@hussain-t The observation by @wpdarren is valid. What you’re describing is correct, but that is particularly the problem why this is not working like it should. We need to make sure that we don’t just keep showing the ProgressBar when there are errors.

In general, looking for undefined values as the indicator for whether to show a loading state is a bit unreliable, for this very reason, that the request could have an error, in which case it should be displayed. We should use ! hasFinishedResolution for the relevant selector to show the loading state.

Can you please open a PR based on main to fix this?

[wpdarren]

QA Update: ✅

• The Adsense Setup V2 Error Notice story displays the error instead of the loading state. Story URL path - /story/modules-adsense-components-setup-v2-setupmain--error-notice
• I also tested this on my test site. The error now appears as expected.