question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Switch Idea Hub module REST route for updating idea states to actually use Idea Hub API

See original GitHub issue

Broken out from #3518: Since the Idea Hub API route to update an idea’s state is still not working correctly, the POST:update-idea-state REST endpoint should be connected to the actual API separately, in this issue.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

  • Verify that the approach in #3767 works as intended when the corresponding Idea Hub API starts to work correctly. If it doesn’t work as intended (see AC) then make necessary changes and send PR for code review

Test Coverage

  • N/A

Visual Regression Changes

  • N/A

QA Brief

  • Activate Idea Hub module
  • Set the custom site URL setting in the Site Kit developer settings to https://www.elasticpress.io/
  • Go to the dashboard and verify that you see new ideas
  • Click on the pin icon to save the idea. Verify that the saved idea has been moved to the “Saved” ideas tab.
  • Refresh the page and verify that the saved ideas list contains the recently saved idea and the new ideas list doesn’t contain it anymore.
  • Now unsave the idea and verify that the idea has been moved to the ideas list (at the end). Plus after refreshing the page you see it in the new ideas list and don’t see it in the saved ideas anymore.
    • NOTE: While the above is what should happen here, there appears to be currently a bug with the API that prevents the first sentence above from working. In other words, the (for now broken) accepted functionality is: When unsaving, at first the idea won’t move back to the “New” tab. But it should at least have been moved there once you refresh the page. This likely needs to be fixed at the API level (also see https://github.com/google/site-kit-wp/pull/3767#discussion_r685573564).
  • Dismiss an idea and verify that the idea doesn’t re-appear after refreshing the dashboard page.

Changelog entry

  • Implement functionality for saving and dismissing an Idea Hub idea.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:9 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
eugene-manuilovcommented, Aug 9, 2021

@felixarntz QAB is added.

1reaction
felixarntzcommented, Aug 9, 2021

@eugene-manuilov Can you also add a QA Brief here? It should include some basic testing of saving, unsaving, and dismissing, since that’s now enabled by this API endpoint.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Switch Idea Hub module REST routes to actually use ... - GitHub
Switch Idea Hub module REST routes to actually use Idea Hub API #3518 ... GET:new-ideas; GET:saved-ideas; POST:update-idea-state.
Read more >
Hub REST API Reference - Help - JetBrains
This section contains all currently public REST API methods in Hub. Auth Modules · Auto Join Groups of Auth Module.
Read more >
REST API reference - Product Documentation | ServiceNow
The CI Lifecycle Management API provides endpoints to manipulate configuration item (CI) operational states and apply CI actions.
Read more >
Zalando RESTful API and Event Guidelines
Embracing 'API as a Product' facilitates a service ecosystem, which can be evolved more easily and used to experiment quickly with new business...
Read more >
Understand Open Shortest Path First (OSPF) - Design Guide
OSPF uses IP multicast to send link-state updates. ... The idea behind this is that routers have a central point of contact for...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found