question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Update link style within error notices

See original GitHub issue

Feature Description

The current styling of links within error notices looks a bit off and should be updated for better adherence to M3. We should be using an alternate color for on-error surfaces rather than the default link color in this context.

image

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • Any link on the red GM2+ background (mainly used for errors) should have the color set to #7A1E00 as per the Figma designs (On Error Container).

Implementation Brief

  • Using assets/sass/components/global/_googlesitekit-cta.scss,
    • Add styles for the .googlesitekit-cta--error a selector whereby the color is #7A1E00 ($c-utility-on-error-container).

Test Coverage

  • No new tests to be added.

QA Brief

  • Doublecheck new CTA Link styling in Storybook
    1. Start storybook
    2. Go to story “Global > Links” and check the External Link
    3. Go to story “Components > Report Error > Default ReportError” and check the external link.

Changelog entry

  • Update link style within error notices.

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:8

github_iconTop GitHub Comments

2reactions
asvinbcommented, Nov 4, 2022

@FlicHollis @eclarke1 Just FYI, even though it’s an UI issue, I’ve estimated it to be 3 since it’s a quite straightforward fix and easy to QA.

1reaction
techanvilcommented, Nov 17, 2022

Hi @derweili, thanks for bringing this up. Sometimes details will get missed in an IB and it’s usually fine to cover this in the PR, with a note about it under Relevant technical choices which you’ll see in the PR template when you create it.

However if you do feel the the change would significantly impact the scope or estimate, then yes it could be appropriate to move the issue back to IB to spec it out or create a new issue as appropriate.

Please take a look, if you think you can fix it in this PR go for it but otherwise feel free to move it back to IB with a note on the issue and we can figure it out from there.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Styling links - Learn web development | MDN
To learn how to style link states, and how to use links effectively in common UI features like navigation menus. Let's look at...
Read more >
Link color wont change despite CSS styling - Treehouse
So I've got an issue with a project I'm working on. At the bottom of my page I have a copyright notice with...
Read more >
Error on change style of page with jquery - Stack Overflow
In your main.js , change clickMenu function. Wrap a call to $('html, body').animate in a condition that section must ...
Read more >
Change the Color of Validation Error Messages - Alchemer Help
Just go to the Style tab and scroll to the bottom of the survey preview and click the link to access to HTML/CSS...
Read more >
Style Sheets in HTML documents - W3C
Authors may link this style sheet to their source HTML document with the LINK element: <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found