Update Storybook module settings stories to use createLegacySettingsWrapper
See original GitHub issueBug Description
Currently our Storybook stories for module settings each use the same Settings wrapper component which is used just for rendering in Storybook. This is defined in the stories file for multiple modules’ settings stories, e.g.:
In #1715 we introduced the createLegacySettingsWrapper utility for reducing this boilerplate needed for each module’s settings stories.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Settingswrapper components defined instories/module-*-settings.stories.jsfiles should be removed- Stories in
stories/module-*-settings.stories.jsshould be refactored to usecreateLegacySettingsWrapper
See Tag Manager for example usage: https://github.com/google/site-kit-wp/blob/20f826af64092da7633d94ead7d23a75667762a7/stories/modules-tagmanager-settings.stories.js#L35
Implementation Brief
- Update
stories/module-*-settings.stories.js(excepttagmanageras it is already done) to use the new utility instead of the inlineSettingscomponent definition
QA Brief
- N/A
Changelog entry
- N/A
Issue Analytics
- State:
- Created 3 years ago
- Comments:10 (6 by maintainers)
Top Results From Across the Web
Configure Storybook
The main.js configuration file is a preset and, as such, has a powerful interface, but the key fields within it are: stories ......
Read more >storybook/MIGRATION.md at next - GitHub
Storybook is a frontend workshop for building UI components and pages in isolation. Made for UI development, testing, and documentation.
Read more >Configuring Storybook: 6 Tips You Can't Miss - Medium
webpackFinal - custom webpack configuration. 4. babel - custom babel configuration. module.exports = {// The location of your stories stories: ...
Read more >Visual Testing with Storybook | Gatsby
Manual configuration. TypeScript Support; Writing stories; Additional resources. Note: Make sure that you use Storybook version >=6.3.0 before following the ...
Read more >Storybook - no stories showing up in typescript project with ...
It seems like the babel plugin transform-es2015-modules-amd doesn't fit right with storybook since sb still uses your babel configuration.
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found

IB ✅
Hello, can I take this issue as a first timer?