question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

When an idea has multiple topics, we need to separate them with a comma or another separator because without a separator it seems like there is one big topic

See original GitHub issue

Bug Description

image

image

image

Please note @Pratheep-lab’s comments in Asana: https://app.asana.com/0/1200491083500938/1200749910371621

Steps to reproduce

  1. Go to ‘…’
  2. Click on ‘…’
  3. Scroll down to ‘…’
  4. See error

Screenshots

Additional Context

  • PHP Version:
  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Plugin Version [e.g. 22]
  • Device: [e.g. iPhone6]

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The topics that appear above an idea in the Idea Hub widget should have their styling adjusted so that they can be clearly visually separated (in case there are multiple topics).
  • For that purpose, the light-blue background as seen in the last design screenshot above should be used.

Implementation Brief

Using assets/sass/components/idea-hub/_googlesitekit-idea-hub-dashboard-ideas-widget.scss

For the class .googlesitekit-idea-hub__idea--topic, add the following rules

background-color: $c-solitude;
border-radius: 2px;
padding: 1px 6px;

This is done on this open PR - https://github.com/google/site-kit-wp/pull/3867

Test Coverage

  • No changes

Visual Regression Changes

  • No changes

QA Brief

  • Go to the dashboard page.
  • Verify that idea topics have a light-blue background as shown in the last design screenshot above.

Changelog entry

  • Update styles of the topic idea element to have a light-blue background.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:11 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
danielgentcommented, Aug 17, 2021

looks now

It looks a lot better now 😄 @wpdarren @Pratheep-lab

This is on this PR @eugene-manuilov https://github.com/google/site-kit-wp/pull/3893 . I’ll assign the ticket to you now

1reaction
wpdarrencommented, Aug 17, 2021

QA Update: ❌

@eugene-manuilov the font color is #5f6368 on my test site but on the designs it’s #333333. Also, the character spacing appears to be tight. Have to say the font color and character spacing makes the text much easier to read on the Figma.

Verified:

Verified that idea topics have a light-blue background as shown in the screenshot.

image

Read more comments on GitHub >

github_iconTop Results From Across the Web

Commas | Technical Writing Strategies - Lumen Learning
Complete ideas need to be separated by a comma because, by definition, they could be grammatically autonomous, but the writer is choosing to...
Read more >
Major Comma Uses
Thus, not all adjectives should be separated from one another by a comma. Look at this example. In this example, no comma belongs...
Read more >
Rule 1. To avoid confusion, use commas to separate words ...
Use a comma after phrases of more than three words that begin a sentence. If the phrase has fewer than three words, the...
Read more >
Commas - Boundless Writing
Commas have many uses, but the situations in which they are used can be broken down into four major categories: Put a comma...
Read more >
Commas - UNC Writing Center
You should always have a comma before FANBOYS that join two independent clauses (two subjects and two verbs that make up two complete...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found