WP Dashboard: Update the popular pages widget to correctly display the gathering data state.

Feature Description

Following on from the work in #4711, on the WP Dashboard, when the Analytics widgets Unique Visitors and Avg. Time on Page are showing the gathering data… text, the blue Analytics Gathering Data CTA should not be displayed.

See related comments on the PR for #4711 for more information.

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• These changes are only relevant when the zeroDataStates feature flag is enabled.
• The WPDashboardPopularPages component should display the gathering data state correctly when the isGatheringData returns true for the Analytics module.
• In order to reproduce this scenario, follow the QA Brief in #4711.

Implementation Brief

• In the assets/js/components/wp-dashboard/WPDashboardPopularPages.js file:
  • Get the zeroDataStates feature flag.
  • Update the condition that returns the WidgetReportZero element to do so only when the zeroDataStates feature flag is not enabled. https://github.com/google/site-kit-wp/blob/372a83b9ac570045311cefa1397c0b6f4230c454/assets/js/components/wp-dashboard/WPDashboardPopularPages.js#L114-L116
  • Add the gatheringData={ isGatheringData } property to the ReportTable element.

Test Coverage

• N/A

QA Brief

• Using the tester plugin, force the “gathering data” state.
• Activate the “zeroDataStates” feature flag
• Go to the main WordPress dashboard
• Verify that the “Analytics” widgets show the “gathering data…” text instead of the blue CTA.
• Disable the “zeroDataStates” feature flag
• Verify that the blue CTA is displayed.

Changelog entry

• Update gathering data UI in WordPress Dashboard widget.

[tofumatt]

ACs here look great, so moving this to IB 👍🏻

[felixarntz]

Approval ✅

Aside: I opened #4990 to complete some missing Storybook coverage around this area.