Batching settings is ignored

Hi,

I am running a nodejs-pubsub client on Windows and Linux and finding this bug on both Platform.

The batching parameter of topic.publisher() is ignored when message are published, despite being visibile and correctly set-up when I read from publisher.settings.batching.

I tried to set the maxMessages parameter to 1 but my messages are still published in batches.

I tried to set BatchSettings(max_messages=1) with Python (with the same subscribers) and it worked.

Environment details

• OS: Ubuntu 17.10 , 64 bits
• Node.js version: 6.11.4
• npm version: 3.5.2
• google-cloud/pubsub version: 0.16.4

Steps to reproduce

const PubSub = require('@google-cloud/pubsub');

const pubsub = new PubSub({});

const topic = pubsub.topic('mytopic');

const publisher = topic.publisher({
  batching: {
    maxMessages: 1
  }
})

const callback = function (err, messageId) {
  if (err) {
    console.log(err)
  }
};

for (var i = 1; i <= 3; i++) {
  publisher.publish(Buffer.from('This is a message'), { myattribute: 'attributeValue'}, callback);
} // These messages will be sent in a batch rather than as 3 independant messages

Thanks for your help!

[Etendard7]

Ok thanks! I have reported the issue on the github of the python library. FYI : https://github.com/GoogleCloudPlatform/google-cloud-python/issues/4912

[callmehiphop]

@Etendard7 I’m going to close this issue. Moving forward Node is going to adopt Python’s strategy for flow control. Thanks again for bringing this to our attention!