Cannot build v0.28.1

• OS: Ubuntu
• Node.js version: 10.15.1
• npm version: 6.4.1
• @google-cloud/pubsub version: 0.28.1

Steps to reproduce

In a new project:

• npm install typescript @google-cloud/pubsub
• Create a file src/index.ts with content:

import { PubSub } from "@google-cloud/pubsub";

console.log("Hello world!");

• npx tsc --init
• Set rootDir and outDir in tsconfig.json.
• run npx tsc and the console output should give you a typescript error:

~/code/labs/pub-sub (master #)$ npx tsc

node_modules/google-gax/build/src/streaming.d.ts:47:42 - error TS2507: Type '{ default: DuplexifyConstructor; obj(writable?: Writable | undefined, readable?: Readable | undefined, streamOptions?: DuplexOptions | undefined): Duplexify; }' is not a constructor function type.

47 export declare class StreamProxy extends Duplexify {
                                            ~~~~~~~~~
Found 1 error.

I tried to downgrade the pubsub version a bit but it didn’t solve it.

[marcusradell]

I can confirm that it builds with const { PubSub } = require("@google-cloud/pubsub");.

I haven’t run any code yet to try it out, but hopefully this unblocks us from using the latest version.

Well done with the speedy work here! 🥇

From my point of view, you can close the issue unless you want to keep it open to solve the root cause.

[cdock1029]

typescript 3.3.3333

Same error as @marcusnielsen, in gax-nodejs/src/streaming.ts they are doing:

import * as Duplexify from 'duplexify';

export class StreamProxy extends Duplexify {...}

Edit: removing this is not ideal, causes errors importing other modules. Making this change in my tsconfig.json eliminated the build error:

{
- "esModuleInterop": true,
+ "esModuleInterop": false,
}

esModuleInterop:

Emit '__importStar' and '__importDefault' helpers for runtime babel ecosystem
compatibility and enable '--allowSyntheticDefaultImports' for typesystem compatibility.
Requires TypeScript version 2.7 or later.

Seems import * as is discouraged:

https://github.com/Microsoft/TypeScript/pull/19675

Edit

Try this instead of removing esModuleInterop to isolate fix only to this library:

const PubSub = require('@google-cloud/pubsub').PubSub