Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

flowControl.maxMessages is being ignored

See original GitHub issue

flowControl.maxMessages is seemingly being ignored. I’ve created a small focused test repo to highlight the issue.

Environment details

OS: Mac OSX
Node.js version: 8.16.2
npm version: 6.4.1
@google-cloud/pubsub version: 1.1.2

Steps to reproduce

See: https://github.com/sjb933/gcloud-pubsub-maxMessage-bug

Clone project
npm install
Open test.ts and populate GOOGLE_PROJECT_ID with a proper project ID which you have authenticated access to
Execute the test with npm start
Observe the output

Observations:

Expected: 10 messages published, only 2 process concurrently.

Actual: 10 messages published, all 10 process concurrently.

Issue Analytics

State:
Created 4 years ago
Comments:6 (3 by maintainers)

Top GitHub Comments

1reaction

callmehiphopcommented, Oct 17, 2019

I think it shipped with v0.23.0 which was released back in January. Before that we had behavior that mirrored setting it to false.

1reaction

sjb933commented, Oct 17, 2019

@callmehiphop confirmed, allowExcessMessages: false resolves the issue. I’m in the process of updating to newer libs and this was revealed in our consuming code’s tests.

Was this a new option, or did it perhaps default to false before?

Thanks you for the quick support!