question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Creating 2 reports against the same base URL with a query parameter only shows the 1 check in GitHub

See original GitHub issue

Describe the bug

When I run a Lighthouse CI Collect against two url’s such as the example below

  • http://localhost:3000/foo
  • http://localhost:3000/foo?example=bar

The two Lighthouse reports are generated successfully and stored in storage.googleapis.com. In GitHub, when the action has finished and I have a token setup to add in the outcome of both of these reports - I only see the report generated for http://localhost:3000/foo?example=bar in the checks list.

To Reproduce Steps to reproduce the behavior:

Using the configuration below, run lhci autorun against 2 URL’s with the same base URL. One of them should provide a query string.

module.exports = {
  ci: {
    collect: {
      url: [
        'http://localhost:3000/foo',
        'http://localhost:3000/foo?example=bar'
      ],
      startServerCommand: 'yarn start',
      numberOfRuns: 3
    },
    upload: {
      target: 'temporary-public-storage'
    }
  }
};

Expected behavior

Two reports should show in GitHub checks when using a token to report the checks.

Logs/Screenshots

When running ``lhci autorun`, 2 Lighthouse reports have been generated. Screenshot 2022-03-10 at 17 28 34

When viewing in GitHub, only one of these reports shows. Screenshot 2022-03-10 at 17 28 52

Environment (please complete the following information):

  • OS: Github Actions
  • Browser:
  • Version:

Issue Analytics

  • State:open
  • Created 2 years ago
  • Reactions:1
  • Comments:5

github_iconTop GitHub Comments

1reaction
GeorgeA93commented, Mar 11, 2022

We have also been seeing this behaviour. I believe the query params are being stripped when generating the label for github: https://github.com/GoogleChrome/lighthouse-ci/blob/main/packages/cli/src/upload/upload.js#L190

We can customise the upload prefix, but that’s about it. I wonder if we want an option to preserve query params in the label, but open to other ideas!

0reactions
ilyichcoderminecommented, Oct 7, 2022

any update on this?

Read more comments on GitHub >

github_iconTop Results From Across the Web

Using query parameters to create a pull request - GitHub Docs
Use query parameters to create custom URLs to open pull requests with pre-populated fields. You can use query parameters to open pull requests....
Read more >
Creating an issue - GitHub Docs
Query parameters are optional parts of a URL you can customize to share a specific web page view, such as search filter results...
Read more >
Configuring code scanning - GitHub Docs
This article is about running code scanning on GitHub using actions. Before you can configure code scanning for a repository, you must set...
Read more >
About status checks - GitHub Docs
Status checks are based on external processes, such as continuous integration builds, which run for each push you make to a repository.
Read more >
Creating CI tests with the Checks API - GitHub Docs
Re-run check runs when a user requests that action on GitHub. Part 2: Build on the CI server framework you created by adding...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found