question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Include timing details in GitHub Status Check

See original GitHub issue

I’d love to see my actual timing numbers (in milliseconds for FCP and TTI) in my GitHub status checks like I can with the categorical scores. I use the Lighthouse CI integration for GitHub to see how my changes affect my site’s speed and just recently moved from using the basic “category” assertions to paying specific attention to my FCP and TTI times. I’ve added warn and error for my short-term goal and my current threshold for acceptable, but I want to see the progress I’m making without fishing through my build output/log in the GitHub Actions screens.

I’d love to be able to configure the message presented by the GitHub status check with richer information than just pass, pass w/warnings, or fail. See screenshot below for an idea of what I’ve got in mind.

I’ve considered looking into a bot to add a comment for every build, but that seems noisy. I also considered using a separate Lighthouse server to track my results, but I want the output right in my pull request. Since I could see the category scores, now I’ve got this idea the same kind of thing is possible for performance timing events.

Current: GitHub Action showing tests passing with warnings

Idea: GitHub Action showing tests passing 'first-contentful-paint: 2488 (WARN: >2200)

Issue Analytics

  • State:open
  • Created 2 years ago
  • Comments:6 (4 by maintainers)

github_iconTop GitHub Comments

4reactions
patrickhulcecommented, May 11, 2021

Thanks for filing @ianjmacintosh! What if LHCI just directly exposed the ability to have a javascript function customize the description? Several people have had several conflicting opinions over the years about what this message should say 😃

Usage would look something like…

lighthouserc.js

module.exports = {
  ci: {
    upload: {
      githubStatusDescription({url, assertionResults, state}) {
        return `Whatever you want: ${assertionResults.map(result => /* ... */)}
      }
    }
  }
}
1reaction
patrickhulcecommented, May 21, 2021

Feel free to go for it @ianjmacintosh! I imagine the trickiest parts are going to be just documenting it accurately since it will require a javascript config in order to work 😃

Read more comments on GitHub >

github_iconTop Results From Across the Web

About status checks - GitHub Docs
Status checks let you know if your commits meet the conditions set for the repository you're contributing to.
Read more >
Enabling GitHub Checks - CircleCI
GitHub Check and GitHub status updates · GitHub Checks are administered from the GitHub UI, and are reported in the GitHub UI per...
Read more >
GitHub Status Checks and Branch Protection Made Easy
In less time than it takes to drink a cup of coffee you can dramatically reduce ... In the final step we will...
Read more >
Using the GitHub Checks API to Link Workflow Statuses in a PR
Status check created with github_token, after clicking on details - note the at the bottom, it links to the action workflow run; Using...
Read more >
How to perform status checks in github repository
and how do I send the message to the GitHub server that the status checks have been cleared. Those checks are updated when...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found