Double-Dollar assertion is overly aggressive
See original GitHub issueThe double dollar assertion: https://github.com/GoogleChrome/lighthouse/blob/e87a8b76e66208be0266c6e3a3b648dbebe79521/lighthouse-core/scripts/i18n/collect-strings.js#L344
Is a bit aggressive, it should check for basic $$
but allow $ICU_0$$ICU_1$
. This should be validated with regex like \$([^$]*?)\$
and asserting that each capture group isn’t empty instead of a more basic \$\$
.
Issue Analytics
- State:
- Created 4 years ago
- Comments:5 (2 by maintainers)
Top Results From Across the Web
Assertion over Aggression - LinkedIn
Unnecessary aggressive behavior leads to toxic work environment. Being assertive instead of aggressive is definitely more natural for me too.
Read more >A Comparison of Non-Assertive, Assertive, and Aggressive ...
Nonassertion is failing to stand up for oneself, or standing up for oneself in such an ineffectual manner that one's rights are easily...
Read more >Differences in assertion and aggression between normal and ...
Abstract. Compared assertive and aggressive behavior of 12 normal and 12 neurotic family triads using the Interpersonal Behavior Schedule and a semi-automated ...
Read more >Feline Behavior Problems: Aggression | Cornell University ...
Aggression, defined as hostile or violent behavior intended to dominate or intimidate another individual, is a fairly common behavioral problem in cats.
Read more >Being assertive: Reduce stress, communicate better
Very aggressive people embarrass, intimidate and scare others and may even be physically threatening. You may think that being aggressive gets you what...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Sorry. From the Chromium slack:
So, this test in Lighthouse is checking for
$$
naively, when it really needs to be checking for$$
but not$ICU_0$$ICU_1$
which is valid.@piotrzarycki go for it. work involved is indeed “good first issue”-level assuming it is just doing what Shane said. it’s just the motivation that is opaque