question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

drop `image-size-responsive` elidedUrl

See original GitHub issue

https://github.com/GoogleChrome/lighthouse/blob/master/lighthouse-core/audits/image-size-responsive.js#L149

This is the only audit that saves a separate “elidedUrl” property. All other audits save the result of URL.elideDataURI to their url property. We should just set url to this elided value, and drop elidedUrl. Otherwise, data uir images failing this audit will make the LHR larger than intended.

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:8 (5 by maintainers)

github_iconTop GitHub Comments

2reactions
prerana1821commented, Oct 15, 2021

Hey @meehawk, yes I’m working on it. Will submit it by tomorrow.

1reaction
prerana1821commented, Oct 17, 2021

@connorjclark, please review my PR. #13226

Read more comments on GitHub >

github_iconTop Results From Across the Web

Responsive images - Learn web development | MDN
The body content has been set to a maximum width of 1200 pixels — in viewports above that width, the body remains at...
Read more >
How to Resize Images Proportionally for Responsive Web ...
Another way of resizing images is using the CSS width and height properties. Set the width property to a percentage value and the...
Read more >
How to make an image responsive in HTML email regardless ...
Your best bet for responsive images would be to have the images as 100% width inside a table that has max-width set. Then...
Read more >
Responsive Web Design Images - W3Schools
Resize the browser window to see how the image scales to fit the page. Using The width Property. If the width property is...
Read more >
How to Resize Images Using CSS for Responsive Web Design
If you're creating a website on Editor X, then you'll find advanced, code-free design capabilities for resizing images at the bottom of this ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found