Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

If all audits in a category are `not applicable` the category should be marked `not applicable`

See original GitHub issue

Feature request summary Currently, if n - 1 audits in a category are marked not applicable, the category score is based on the one applicable audit. If n audits are marked not applicable then the category has a score of 0. This feels like the wrong behavior to me, as the site is not necessarily doing anything incorrectly.

One option could be to set a category score as 100 if no audits are applicable, but this also feels wrong as the website is not necessarily doing anything correctly either in this case.

I propose that in this situation we simply display ‘N/A’ as the category score with a grey circle.

I’d be happy to implement this myself.

What is the motivation or use case for changing this? While I’m unaware of any cases where this would happen with current core categories, I think it is very applicable to plugins. This would specifically be true in the case of mistakenly scanning a site using a plugin for a specific technology, when that technology is not being used on the site.

CC: @brendankenny

Issue Analytics

State:
Created 5 years ago
Reactions:1
Comments:10 (8 by maintainers)

Top GitHub Comments

1reaction

jburger424commented, Sep 1, 2020

@connorjclark Looks like this was resolved with https://github.com/GoogleChrome/lighthouse/pull/11024?

1reaction

exterkampcommented, Jan 28, 2020

We have a consensus on the design https://github.com/GoogleChrome/lighthouse/issues/9803#issuecomment-540771705

@jburger424 do you want to take this on?

Top Results From Across the Web

Auditing Standard No. 3 - PCAOB

Introduction. 1. This standard establishes general requirements for documentation the auditor should prepare and retain in connection with engagements ...

Consideration of Laws and Regulations in an Audit of ... - AICPA

.01 This section addresses the auditor's responsibility to consider laws and regulations in an audit of financial statements. This section does not apply...

Final Rule: Revision of the Commission's Auditor ... - SEC.gov

For example, the final rule does not ban all valuation and appraisal services; its restrictions apply only where it is reasonably likely that...

Government Auditing Standards 2018 Revision

The 2018 revision of Government Auditing Standards is effective for financial audits, attestation engagements, and reviews of financial.

CE marking – obtaining the certificate, EU requirements

You can find this information in the relevant legislation applicable to your product: check the rules by product category. This step is not...