Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

lhr.stackPacks doesn't make the proto round trip

See original GitHub issue

you’ll see this if you run yarn update:sample-json on master. stackPacks will be deleted and then npx jest proto-test.js will fail.

Since CI only runs yarn diff:sample-json (just regenerating the original json, not the proto round-trip json), as long as stackPacks was manually added to sample_v2_round_trip.json, everything will be green on Travis 😃

@exterkamp were the proto changes in #7243 not sufficient to get this automatically in the round trip result? I haven’t been able to get good insight into why json_roundtrip_via_proto.py is dropping it.

Issue Analytics

State:
Created 4 years ago
Comments:7 (5 by maintainers)

Top GitHub Comments

2reactions

patrickhulcecommented, Apr 15, 2019

We can add a test stack pack to sample v2 to make it non-empty?

That seems like the most reasonable thing we care about 😃

0reactions

exterkampcommented, Apr 15, 2019

We do have some very limited transformations we can do. And I mean very limited. Like renaming. Or, null if doesn’t exist, things like that. There is a possibility I could get this to work in Apiary. But that is a huge unknown and would be much more difficult than any other solution.