max-wait-for-load not working

I tried adding details in https://github.com/GoogleChrome/lighthouse/issues/11615 but dependabot marked and closed it as a duplicate. The max-wait-for-load flag doesn’t seem to be working unless I’m misunderstanding.

[patrickhulce]

That won’t catch any hanging in the audit process once Chrome is out of the picture (which is why we recommend and provide examples of the child process model), but it should solve this specific PROTOCOL_TIMEOUT issue 👍

Thanks for sharing it with others @adamhenson 😃

[adamhenson]

For anyone who comes across this, I’m creating my own timeout programmatically with the following code. If someone sees something wrong with this, please let me know. The only caveat is that it masks the true problem (if a PROTOCOL_TIMEOUT would have occurred - you won’t know). This is needed for me because I run a gigantic queue of Lighthouse audits and I can’t have a single Lighthouse process hang for 10 minutes.

The below code is a simplified version of what I’m doing and may not work exactly as is. Hope it helps others.

const TIMEOUT = 60000;
const TIMEOUT_ERROR_MESSAGE = 'TIMEOUT';
let chrome;

try {
  chrome = await chromeLauncher.launch({
    chromeFlags: options.chromeFlags,
    port: options.port
  });

  const result = await Promise.race([
    lighthouse(url, options, config),
    new Promise(resolve => {
      setTimeout(resolve, TIMEOUT, TIMEOUT_ERROR_MESSAGE);
    }),
  ]);

  if (result === TIMEOUT_ERROR_MESSAGE) {
    throw Error(TIMEOUT_ERROR_MESSAGE);
  }

  await chrome.kill();

  return result;
} catch (error) {
  // make sure we kill chrome
  if (chrome) {
    await chrome.kill();
  }

  throw error;
}