Remove rawValue from Audit.Result

What is the current behavior?

rawValue is still in each Audit in the LHR, but the Metrics audit contains all rawValue information and so rawValue is redundant.

[brendankenny]

But it is still used internally in the auditProduct objects.

Since (I believe) this isn’t blocking the proto work, I think we should do this right and eliminate the rawValue from the product as well. Otherwise it will live (and rot) forever for no benefit but being able to ignore it today.

This might be one of those cases we all need to get in a single (virtual) room and make sure every useful rawValue has a reasonable details that handles it

[brendankenny]

In addition to what @patrickhulce said,

Hey @brendankenny , this is a fairly breaking change for us. We were using rawValue’s boolean value to determine audit pass/fail status, or if it was a numerical value, some custom threshold to then get a true/false from it.

Yes, sorry about that. We tried to call it out prominently in the release notes, but maybe a migration guide would have been a good idea.

As I outlined in https://github.com/GoogleChrome/lighthouse/pull/8421#issuecomment-484790725, rawValue was pretty much historical accumulation and its ambiguity was making each of its possible use cases less useful. In order to have raw metric values in the audit results and to keep the property from becoming unfocused over time again we narrowed the concept down to the more explicit numericValue.

We could make a similar thing for the boolean-ish audits, but as @patrickhulce notes, scoreDisplayMode: 'binary' and the score already handle this case, so it’s probably not worth adding a redundant property.

(it was also never inherently clear what most of those audits should be returning for a ‘rawValue’ in the first place. e.g. for is-on-https, should rawValue have been the number of requests not on https or just a boolean state because (as browsers treat a page load) either all requests were secure or they weren’t? Both possible values are useful. Instead we have explicit places for both of those numbers: boolean goes to the 0/1 score, the number of insecure requests in details.items).