Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

remove without-javascript audit

See original GitHub issue

My home page does not require JavaScript (except to start the service worker) and looks fine with it disabled. I added a <noscript> element and can see its text display, but the test doesn’t care (probably because it doesn’t run).

Provide the steps to reproduce

Run LH on localhost - I’ll upload the latest version to prod in the next few days and update this report.

What is the current behavior?

Test doesn’t even run.

What is the expected behavior?

Test runs and passes

Environment Information

Affected Channels: Extension
Lighthouse version: 100.0.0.0
Chrome version: Google Chrome 85.0.4183.102 (Official Build) (64-bit)
- Revision ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
- OS Linux
- JavaScript V8 8.5.210.20
- Flash 32.0.0.433 /home/gpeterso/.config/google-chrome/PepperFlash/32.0.0.433/libpepflashplayer.so
- User Agent Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.102 Safari/537.36
- Command Line /usr/bin/google-chrome-stable --flag-switches-begin --flag-switches-end
Node.js version: NONE
Operating System: Ubuntu 18.04

Related issues #11455 Failing this previous test may break some subsequent ones, IDK.

Issue Analytics

State:
Created 3 years ago
Comments:5 (2 by maintainers)

Top GitHub Comments

1reaction

brendankennycommented, Sep 18, 2020

I propose just converting the without-javascript check to look for a <noscript> with some textContent

That does mean e.g. example.com (and any other completely static site) would fail the audit 😕 I would guess that those are more common than sites not serving something on http (whether or not it’s a redirect).

Another option worth considering is retiring the without-javascript audit in the next major release. No one has ever really expressed interest or ideas on how to make this obviously ham-fisted audit better and actually test what it claims to be doing. Maybe it’s not worth keeping until (and if) some new approach is developed?

0reactions

paulirishcommented, Nov 10, 2020

We’re going to delete the without-javascript audit for lighthouse v7