Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Report: add more robust handling of default property values stripped by LHR proto

See original GitHub issue

FAQ

Yes, my issue is not about variability or throttling.
Yes, my issue is not about a specific accessibility audit (file with axe-core instead).

URL

https://investmentu.com

What happened?

I’ve set up an LHCI server with PSI auto collect. But I’m getting one tiny issue related to https://googlechrome.github.io/lighthouse/viewer/.

When I click to open any report, the view complains:

Uncaught Error: Error rendering report: Cannot read property 'startsWith' of undefined

Debugging it, I “solved” this issue by setting the second parameter of this function to an empty string as default.

https://user-images.githubusercontent.com/1340508/128362112-8f36fc61-22a6-48b2-a9c9-f28c179d2bd8.mp4

https://user-images.githubusercontent.com/1340508/128362114-a33d036f-8a5f-4229-8ad3-83b11f74adc2.mp4

What did you expect?

The report should be shown properly.

What have you tried?

I’ve used local overwrites to debug and found the solution.

How were you running Lighthouse?

PageSpeed Insights

Lighthouse Version

8.0.0

Chrome Version

No response

Node Version

No response

Relevant log output

No response

Issue Analytics

State:
Created 2 years ago
Comments:11 (6 by maintainers)

Top GitHub Comments

1reaction

paulirishcommented, Aug 5, 2021

@derevandal thanks for the PR! Agree that’ll definitely fix it. We will probably reach a bit deeper to try to fix the root issue, but we definitely appreciate you drafting that.

@connorjclark @brendankenny fixing the root issue feels like… we address any of these situations. I think that’s anything inside a proto Struct… which is just Audit.Details. And then within there its strings of ‘’, numbers of 0, booleans of false, etc.
It does seem that we can allow our renderer to handle these dropped-defaults versions of LHR Audit.details or we do the bookmarked LH replacement thing that connor mentioned. I bring up the larger scope issue in case we could catch some currently-silent bugs by tweaking our renderer types.

1reaction

connorjclarkcommented, Aug 5, 2021

Thanks for the report, we’re looking into it now.

In the future, to save yourself extra effort when reporting bugs, what is most important (and is usually sufficient) is the stack trace of the error, which I was able to find in your video. Sharing here for others:

Repro: https://googlechrome.github.io/lighthouse/viewer/?psiurl=https://www.investmentu.com

Top Results From Across the Web

Properties with default value won't get correct value ... - GitHub

Create any property with (default=value) Insert a new entity with property=othervalue overwriting the default Do a GET on the entity What is the...

Ktc - River Thames Conditions - Environment Agency - GOV.UK

Absolutorium wos, Tai game ban ca lay xu, Qmobile e8 new price in pakistan, Ancoria cyprus, ... 3 8 cap head screw, American...

Automated Malware Analysis Report for https://secure-chsd.org/s/e ...

Windows Analysis Report https://secure-chsd.org/s/e?m= ... Default Accounts, Scheduled Task/Job, Boot or Logon Initialization ... pug-lhr.pubmatic.com.

Default Property Values - MATLAB & Simulink - MathWorks

You can define default property values on three levels: Root — values apply to objects created in current MATLAB ® session. Figure —...

The first two reports issued by the Marine Bioassay Project described the ... Brine used in this test was not heated to more...