bubblewrap 1.3 hangs on iconResponse.buffer()

I updated to bubblewrap/core 1.3.0, and now I’m seeing a hang that happens 90% of the time.

I added some console logs to help narrow down the issue. Here’s what I see:

twa-generator C:\Users\judah\AppData\Local\Temp\pwabuilder-cloudapk-16772EXlDRT8RQ1lc\app\src\main\AndroidManifest.xml Log.js:116 generating icons------------------------ TwaGenerator.js:365 fetching icon https://sadchonks.com/kitteh-512.png TwaGenerator.js:287 successfully fetched icon https://sadchonks.com/kitteh-512.png with status code 200 TwaGenerator.js:294 about to grab buffer for icon https://sadchonks.com/kitteh-512.png

It hangs after “about to grab the buffer”. In particular, that’s this line in TwaGenerator.

In short, it means fetching the image succeeds with a 200 result, but then accessing .buffer() hangs and never resolves. As a test, I did a .buffer().then(…).catch(…) to see it ever succeeded or failed. It did not, neither the then nor the catch is ever hit.

Any idea why .buffer() might be hanging here?

[andreban]

The reason is that chosenIconUrl must be a complete URL, including the origin. In this case, https://sadchonks.com/favicon.png.

[JudahGabriel]

Since the hang is probably an environment issue, I’ll close this for now.

Thanks for the tip about absolute URL for shortcuts. Since we’re not calling fromWebManifestJson, we don’t hit that code, so we must construct the ShortcutInfo objects ourselves. No problem, we’ll pass in the full URL.