Feature request: option to exclude some files

It’ll be great if we could specify files to exclude. Currently, I get this warning WARNING in new Worker() will only be bundled if passed a String. because a dependency dynamically creates workers. But it’s not actionable from me because I don’t control this code.

[s-h-a-d-o-w]

So far, it’s only been discussed that there is a warning and people want to get rid of it. What I’m more curious about is - it’s a warning, so what are the potential issues? Personally, I don’t get why worker-plugin tries to bundle workers of third party libraries in the first place. I would’ve assumed that that’s already taken care of within the library…

[developit]

@s-h-a-d-o-w it’s not really feasible to define what constitutes a third-party library. Things from node_modules could be relying on new Worker('..', {type:'module'}), and this plugin would make them function correctly. Some folks “vendor” their dependencies so they’re not in a directory like node_modules that could be reasonably excluded by default.

At the end of the day, it’s fairly confusing to apply transformations like this only to certain code. This plugin implements a web standard at build time, so it should be pretty safe to run on all code.

In terms of any ill-effects related to the warning, it’s really there for the opposite reason: the warning points out failed cases where folks do want WorkerPlugin to bundle a Worker, where static analysis bails out and it can’t figure out the worker’s entry module:

import workerSrc from './somewhere-else';
new Worker(workerSrc, { type: 'module' });

The warning points out these cases because they’re likely errors in first-party code.

That all being said, I do think the warnings are too aggressive right now. Currently, any usage of new Worker() will trigger the warnings - that’s a little much, since even non-module workers will trigger it, and they aren’t even supported by the plugin. I’ll open a PR to make it so that only module workers receive warnings.