Libraries BOM for Guava's -jre flavor (Java 8+)
See original GitHub issueShall we create the Libraries BOM with Guava’s -jre flavor?
As of now, the Libraries BOM uses Guava’s -android flavor. This flavor of Guava does not have methods for Java 8+, such as CacheBuilder.expireAfterWrite(java.time.Duration)
. (Duration class was introduced in Java 8.) If a project uses the Libraries BOM and depends on a library that touches the Java 8+ methods (for example com.google.cloud.bigdataoss:gcsio
), the JVM throws NoSuchMethodError
:
java.lang.NoSuchMethodError: com.google.common.cache.CacheBuilder.expireAfterWrite(Ljava/time/Duration;)Lcom/google/common/cache/CacheBuilder;
at com.google.cloud.hadoop.gcsio.GoogleCloudStorageImpl.<init>(GoogleCloudStorageImpl.java:149)
Therefore, Java 8 users in such situations need to override the version of Guava. The step is documented in https://github.com/GoogleCloudPlatform/cloud-opensource-java/wiki/The-Google-Cloud-Platform-Libraries-BOM#guava-versions--jre-or--android . As noted there we cannot override Gradle’s enforcedPlatform
keyword, which controls transitive dependency versions. (platform
works but this does not control transitive dependencies) Maven users can override transitive dependencies by adding guava entry in the dependencyManagement
section.
Given that Java 8 users are majority right now (Java 7 users are few percent in GCP), shall we target for Java 8 users as the main audience?
This request is from @kileys (Dataflow team). The options listed below are prepared by suztomo.
Option 1: change main target audience to Java 8 users
- The Libraries BOM includes Guava’s -jre flavor that supports Java 8 operations
- Java 7 users can override the guava version as in the wiki page.
Option 2: two flavors of the Libraries BOM
- We publish 2 flavors of the Libraries BOM for both Java 8+ and Java 7.
Issue Analytics
- State:
- Created 3 years ago
- Comments:6 (6 by maintainers)
@kileys We’re going to keep the libraries BOM’s Guava as it is until we stop supporting Java 7. When Beam publishes its Beam GCP BOM for Beam users early next year, add the override to choose Beam’s Guava flavor.
This enables Beam users to select appropriate Guava version (rather than them relying on the Libraries BOM).
Will LTS work moot this?