Ideas for skipping cleanup on error?

Just ran an apply/destroy cycle through tftest, where on destroy I ran into a timing error when waiting for a resource to change to the expected state:

Error: Error waiting for VPC Peering Connection (pcx-....) to be deleted: timeout while waiting for state to become 'rejected, deleted' (last state: 'active', timeout: 1m0s)

Ok, not great, but no big deal, just go into the test directory and re-run destroy… Except, the tfstate file is gone, so can’t do that!

[grahamhar]

Yes you get a test pass which in our use case is what we want.

If that is not what you want add a pytest.fail to the except block

[grahamhar]

@ludoo Sorry I probably should have provided more explanation, let me provide a few examples of how I think the approach I suggested helps.

1. Issue with Terraform code under test that results in a failure under the apply phase, this captures the exception thrown from the apply and runs a destroy which should clean up any resources already created. As Terraform in many cases doesn’t validate parameters it’s easy to get 400 type response back which halt execution leaving some resources created.
2. Issue in Destroy caused by a timeout, generally when this happens a second run of destroy would rectify this, not perfect but we’ve found this to be the case.
3. Occasionally we get race conditions like a policy on an S3 bucket trying to be deleted while another S3 operation is underway, again the second attempt in the except block normally resolves this.

I agree it is probably a good idea to set cleanup_on_exit to False.