question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

GF Check 130: Why is -20 the maximum italic angle?

See original GitHub issue

Observed behaviour

Libre Caslon Italic gets the following “fail” message:

🔥 FAIL: Checking post.italicAngle value. - com.google.fonts/check/130 - 🔥 FAIL The value of post.italicAngle must be changed from -22.583 to -20. [code: >20 degrees]

However, the italic really does have an italic angle of more than 20 degrees.

image

I can’t find any specification that limits italicAngle to less than 20 degrees. The MS Typography spec for <post> simply says:

Italic angle in counter-clockwise degrees from the vertical. Zero for upright text, negative for text that leans to the right (forward).

I imagine this is just a sanity check … but calling it a “fail” seems like overkill.

Expected behaviour

If there is no documented problem with >20° italic angles, we should either:

A. Remove this as a check

or

B. Make the >20° check into an “info” check, if we think people may have set it incorrectly when it’s a high value. If this is the case, we might want to also adjust the message to reflect this objective – something like:

ℹ️ INFO The value of post.italicAngle is -22.583, which is significantly higher than most fonts. Check if the italic angle is set correctly. [code: >20 degrees]

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:6 (4 by maintainers)

github_iconTop GitHub Comments

1reaction
davelab6commented, Nov 12, 2018

I think 20 is just made up as an absurdly high amount. Seems to be too low 😉

I think fail at 30 and warn at 20 is good. Should also check for negative values, if not already.

0reactions
davelab6commented, Nov 13, 2018

Is there documentation of the distinctions between fail/warn/info/pass, especially in context of what’s expected for publication to the GFonts library?

I guess I have described it in the Typecon 2018 presentation deck but it does seem that this has not been properly documented. Let’s track in another issue.

Meanwhile, I made a PR to address this concern.

Read more comments on GitHub >

github_iconTop Results From Across the Web

TikZ and pgf
The pgf package, where “pgf” is supposed to mean “portable graphics format” (or “pretty, good, functional” if you prefer...), is a package for...
Read more >
Numerical Investigation on the Role of Mechanical Factors ...
We defined a new measure, ω, for quantifying the amount of GF in different numerical models that is defined as area between the...
Read more >
A Table of Frequently Used Radioisotopes
For β emitters the maximum energies of the continuous β-ray spectra are given. '→' denotes the decay to the subsequent element in the...
Read more >
fontbakery/CHANGELOG.md at main · googlefonts ... - GitHub
[com.google.fonts/check/description_max_length]: Recent requirement from GF marketing team is to remove character limit on description. GF specimen page has ...
Read more >
Emergency Severity Index (ESI): A Triage Tool for Emergency ...
the largest evaluation of ESI in pediatric patients ... ED physicians and 17 ED nurses scored 20 pediatric ... Acute narrow-angle glaucoma.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found