question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

featureNames inside non-stylistic-set features raises feaLib error

See original GitHub issue

When trying to build Fira Code https://github.com/tonsky/FiraCode/blob/390c41cc94bb4a33630acef3933bce7e09a9fb34/FiraCode.glyphs

I get this error:

[~/ws/FiraCode] fontmake -g FiraCode.glyphs -o ttf --output-path FiraCodeLight.ttf -i "Fira Code Light" 
INFO:fontmake.font_project:Building master UFOs and designspace from Glyphs source
INFO:glyphsLib.classes:Parsing "FiraCode.glyphs" file into <GSFont>
INFO:fontmake.font_project:Interpolating master UFOs from designspace
INFO:fontmake.font_project:Generating instance UFO for "Fira Code Light"
INFO:fontmake.font_project:Building TTF for FiraCode-Light
INFO:ufo2ft:Pre-processing glyphs
INFO:ufo2ft.filters.base:Running EraseOpenCornersFilter on FiraCode-Light
INFO:ufo2ft.filters.base:Running DecomposeComponentsFilter on FiraCode-Light
INFO:ufo2ft.filters.base:Running RemoveOverlapsFilter on FiraCode-Light
INFO:ufo2ft.filters.base:Running CubicToQuadraticFilter on FiraCode-Light
INFO:ufo2ft.filters.cubicToQuadratic:New spline lengths: 1: 345, 2: 2869, 3: 1186, 4: 369, 5: 40, 6: 7
INFO:ufo2ft:Building OpenType tables
fontmake: Error: In 'FiraCode.glyphs' -> 'master_ufo/FiraCode.designspace' -> 'instance_ufo/FiraCode-Light.ufo': Compiling UFO failed: instance_ufo/FiraCode-Light.ufo/features.fea:863:1: Expected glyph class definition or statement: got NAME featureNames

The line reported is this:

feature zero {
featureNames {
  name "Zero with a dot inside";
};
sub zero by zero.zero;
sub zero.tosf by zero.tosf.zero;
} zero;

The same glyphs file is compiled fine with fontmake from August 9, 2021.

I’d appreciate any help! Thanks

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:7 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
tonskycommented, Mar 15, 2022

I am building it from a script. Some of the features are auto-generated, so I automated this

0reactions
anthrotypecommented, Mar 15, 2022

@tonsky i’m curious, did you edit the .glyphs source file in a text editor to add that or you did from within Glyphs.app itself?

Read more comments on GitHub >

github_iconTop Results From Across the Web

SKLearn warning "valid feature names" in version 1.0
Initially I was sending dataframe as input to fit with headers and I got the error. When I trimmed to remove the headers...
Read more >
feaLib: Read/write OpenType feature files - fontTools
fontTools' feaLib allows for the creation and parsing of Adobe Font Development Kit for ... Parses a featureNames statement found in stylistic set...
Read more >
Remove lite user registration from Console UI - Wso2/Product-Is
Issue Title Created Date Comment Count Updated Date links osu‑stable bug 4 2022‑01‑31 2022‑10‑23 LoadBalancer unreachable outside of cluster 17 2022‑04‑06 2022‑09‑27 Location of documentation 5...
Read more >
TONSKY GitHub Recent Activities - GiTopX
@tonsky. tonsky closed an issue in googlefonts/fontmake Mar 15, 2022. featureNames inside non-stylistic-set features raises feaLib error #864.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found