question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Code Quality: Move `PanelTypes` from `design-system`

See original GitHub issue

Task

As discussed in https://github.com/GoogleForCreators/web-stories-wp/pull/10452#issuecomment-1060435885, PanelTypes shouldn’t be in the design-system package.

Alternatives Considered

Additional Context

https://github.com/GoogleForCreators/web-stories-wp/pull/10452

Issue Analytics

  • State:open
  • Created 2 years ago
  • Comments:5

github_iconTop GitHub Comments

1reaction
swissspidycommented, Apr 12, 2022

Ah you’re right; dang I did not realize that.

1reaction
swissspidycommented, Apr 11, 2022

After #11096 we can now theoretically just move the PanelTypes to story-editor again (making it a dependency of element-library.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Code Quality - GitLab Documentation
Code Quality Widget. Moved to GitLab Free in 13.2. Going a step further, GitLab can show the Code Quality report right in the...
Read more >
DesignSystems.com
Design & Development. Collaborations in code ; Schema by Figma. Talks and conversations ; Operations. Process & People ; Getting Started. Best in...
Read more >
Design Systems Handbook - DesignBetter
Documentation helps promote those new patterns, reduce the need to write new code, and makes implementation easy with code examples and guidelines.
Read more >
Best practices for building a design system - Enonic
You should have an established design process, which standardizes documentation, hand-off, code review, and quality assurance. A design system ...
Read more >
Contribute - Pluralsight Design System
We want to make it easy to move between packages in the Design System, and following ... Every code submission requires a review...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found