question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Dashboard: Consolidating the FilterProvider to include Author Filter

See original GitHub issue

Feature Description

As part of the feature for Dashboard: Filter by Taxonomy (#11436), our team had to make a larger Filter Provider that held information specific to Taxonomies in order to properly create filters. However, the logic between the Filter by Author work and the Filter by Taxonomy work is separate, in two different places.

This body of work is to unite the two into the larger FilterProvider, so that as we continue onto more filter work in the future (see: #11586), we have one space that holds the logic for each filter, based on the logic of each type of filter that’s needed.

This story will block the work needed to accomplish #11586, as it would be better to improve upon the filter provider the team has built before moving on to adding more filters within the Dashboard space.

This tackles both Code Quality and an Enhancement, supporting further filter work, and improving upon the work delivered by #11436.

Acceptance Criteria

  • Both the Taxonomies filters and the Author filters will exist under one FilterProvider
  • Adding another filter in the future should be made easier by this work: this work should allow one to extend the filters as needed for future work

Alternatives Considered

The alternative would be moving forward to add more filters, which would add more separation between filters (which is what exists today with the last body of work to support Filtering by Taxonomies). It would be ideal if we could accomplish this body of tech debt work prior to that work.

Additional Context

Issue Analytics

  • State:closed
  • Created a year ago
  • Reactions:1
  • Comments:5 (3 by maintainers)

github_iconTop GitHub Comments

2reactions
swissspidycommented, Jun 9, 2022

Another thing I mentioned at https://github.com/GoogleForCreators/web-stories-wp/pull/11625#discussion_r892222772 is to show the taxonomies & author filters also on the list view

Might be something we can do as part of this ticket as well.

1reaction
swissspidycommented, Jun 1, 2022

Appreciate you all keeping an eye on code quality 👍 🚀

Read more comments on GitHub >

github_iconTop Results From Across the Web

Dashboard: Add publish date filter · Issue #11586
Feature Description Users have requested that the Dashboard be updated to ... Dashboard: Consolidating the FilterProvider to include Author Filter #11620.
Read more >
Filter | Pentalogic Technology
The Filter Provider sends the filter you've entered (e.g. “Customer” and ... We're going to use SharePoint Designer to setup Parameters and Filters...
Read more >
RESTEasy JAX-RS - JBoss.org
Obtain form parameters by using HttpServletRequest.getParameterMap(). Use this switch if you are calling this method within a servlet filter or eating the input ......
Read more >
Eclipse Platform
Filtering the Tasks and Problems views ... Merging changes in the compare editor ... Configuring a project to use external annotations
Read more >
e24486.pdf
security providers for use with Oracle WebLogic Server. ... Filters and The Role of the weblogic.security.services.Authentication Class .. 5-20. 5.4.4.3.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found