question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Decoupling: Consistent code location of story locking feature

See original GitHub issue

Task Description

In the editor we moved all story locking (postLock) functionality to wp-story-editor. But there are still some references to postLock in story-editor.

In the dashboard, all story locking functionality is still in dashboard, not in wp-dashboard as one would expect.

Should we move that to wp-dashboard?

Or should we move everything to the “core” packages?

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Comments:12

github_iconTop GitHub Comments

2reactions
sayedtaquicommented, Jan 24, 2022

Oh, I wasn’t aware that the dashboard has story locking functionality too. Thanks for creating an issue for it. I will work on moving it to wp-dashboard and story-editor locking references.

1reaction
sayedtaquicommented, Mar 30, 2022

Initially, moving the “Someone else is already editing this story” to the core editor looked like a good idea, but when I actually started moving, it didn’t feel worthwhile.

  1. If I move PostLock to story-editor and use it in wp-story-editor and pass the props to enable “Take Over” functionality, I end up moving almost everything to achieve that.
  2. If I move only PostLockDialog to story-editor for the sake of keeping the UI in the core editor, we anyways have to pass dialogContent and “Take Over” button from wp-story-editor and it doesn’t feel worthy to only keep such a small component in the core.

May its a wontfix.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Chapter 3.3.1: Decoupling from the UI
We've already looked at how to decouple our tests from implementation details of specific modules of our code (e.g., Vue Components) above.
Read more >
Decoupling revisited: Common pressures, divergent strategies ...
We conclude with a discussion of the implications of our work for both organizational theory and the viability and distinctiveness of the nonprofit...
Read more >
Patterns for Managing Source Code Branches - Martin Fowler
In this case mainline is the master branch in the central repository. While I'm working on my feature, I have my own personal...
Read more >
Decoupling deliberation from competition - LessWrong
It's a place where I don't fully expect it to be possible to fully decouple competition and deliberation, and I wish we had...
Read more >
Decoupling absorption and emission processes in super ...
The absorption process of an emitter close to a plasmonic antenna is enhanced due to strong local electromagnetic (EM) fields.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found