Stuck on an issue?
Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.
And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.
Shopping: Support custom CTA text
See original GitHub issueFeature Description
As of very recently, the default CTA text for the shopping attachment (“Shop now”) can be customized, just like for regular page attachments / outlinks.
See https://github.com/ampproject/amphtml/issues/38080
We now want to add support for this in the editor as well in the PageAttachmentPanel.
To-do:
- Add
cta-textattribute toamp-story-shopping-attachmentallowlist inKSES- Add test for it
- Add CTA text input field to
PageAttachmentPanel- Maybe refactor this component to split it into two, as it is quite large already
- Good time to add some JS unit tests for it as well
- Update
ProductOutputcomponent to addcta-textattribute- Add test for it
Alternatives Considered
Additional Context
Existing CTA text input field for regular page attachments:
Issue Analytics
- State:
- Created a year ago
- Comments:7
Top Results From Across the Web
48 Call-to-Action Examples You Can't Help But Click
Check out these call-to-action examples to inspire you to craft click-worthy CTAs that guide your visitors through the buying journey.
Read more >14 Call to Action Examples (and How To Write an Effective CTA)
1. Adapt your CTA depending of the funnel stage your user is. 2. Make easy for potential customers to engage with your business....
Read more >61 Genius Call-To-Action Examples Everyone Clicks [Tested]
A clever CTA drives downloads and soars sign-ups. Here are 61 super clickable call-to-action examples that catapult conversions.
Read more >9 Brilliant Call To Action Examples For Your Ecommerce Store
What are some examples of call to action? A call to action ( CTA) is a text that motivates the target audience to...
Read more >50 Powerful Call to Action Phrases - Sixads
Things like call to action phrases - also known as CTAs. ... Custom funnels like this can help you understand how customers progress...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
I’ve opened a PR with the update: https://github.com/ampproject/amp-wp/pull/7078
Great. That should align with a 2.3 release and if not a 2.2.5 release with just the spec update.