[v4.0.0-alpha.27] When press on background bottom sheet becomes unresponsive
See original GitHub issueBug
https://user-images.githubusercontent.com/842306/129493938-d48a0c8c-b770-4b36-925f-dc5bd52ee866.mp4
Environment info
Library | Version |
---|---|
@gorhom/bottom-sheet | v4.0.0-alpha.27 |
react-native | 0.64.0 |
react-native-reanimated | 2.3.0-alpha.2 |
react-native-gesture-handler | 1.10.3 |
Steps To Reproduce
- Open bottom sheet (with
[-1, "CONTENT_HEIGHT"]
) snap points - Close it by pressing on backdrop component
- Bottom sheet becomes unresponsive
Describe what you expected to happen:
- Bottom sheet should be responsive and I able to press buttons again
Reproducible sample code
Issue Analytics
- State:
- Created 2 years ago
- Comments:10 (10 by maintainers)
Top Results From Across the Web
android - BottomSheetDialog with transparent background
Create an activity with transparent background just for your bottom sheet. Implement your own layout with a coordinator layout and a bottom sheet....
Read more >material-ui/core/CHANGELOG.md - UNPKG
This release is released to fix the package.json generation in the previous release. 58. 59, ### Core.
Read more >Sheets: bottom - Material Design
Content from a bottom sheet that initially appears below the screen edge can become visible when the sheet is dragged into view.
Read more >react-native-bottom-sheet - bytemeta
react-native-bottom-sheet repo issues. ... [v4.0.0-alpha.27] When press on background bottom sheet becomes unresponsive.
Read more >Metaplex UI doesn't support phantom mainnet endpoint (https ...
... @oyster/common: src/contexts/connection.tsx(556,9): error TS2571: Object is o... ... [v4.0.0-alpha.27] When press on background bottom sheet becomes ...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
I’ve figured out the cause of the bug.
I have used snap points as in example in documentation:
snapPoints={[-1, '100%']}
. From this context It’s expected that-1
value is allowed in snap points array.But this code expects
normalizedSnapPoint
is always non-negative. For-1
this becomescontainerHeight - normalizedSnapPoint = 768.727294921875 - (-1) = 769.727294921875
.https://github.com/gorhom/react-native-bottom-sheet/blob/b65ea0df0de2bd0e6fca35a96a7ed2b4c2d81cb5/src/utilities/normalizeSnapPoint.ts#L19
it should be resolved with https://github.com/gorhom/react-native-bottom-sheet/commit/95ea72a459f96d40ad583c5579cc72f0e128e5dd and released on the next alpha release 👍