Re-Used Notification When Uploading Same File Twice Or More at the same time

Version info

• Android Upload Service version: 3.0.3
• Android version and API version: any
• HTTP stack (e.g. HurlStack or OkHttpStack): HurlStack

What did you expect?

Seperate notification

What happened instead?

Re-used notification

Steps to reproduce (if applicable):

I have the same file uploaded twice or more at the same time. The notification from that different uploads will use the same notification.

Library initialization code:

UploadService.NAMESPACE = BuildConfig.APPLICATION_ID;

Request code:

final MultipartUploadRequest multipartUploadRequest = new MultipartUploadRequest(this, mCurrentPhotoPath, url)
.setNotificationConfig(getNotificationConfig(mCurrentPhotoPath))
.setMaxRetries(0);
multipartUploadRequest.addFileToUpload(uriToUpload.getPath(), "file");
multipartUploadRequest.addParameter("some param key", "value");
multipartUploadRequest.addHeader("some cookie key", "value");
multipartUploadRequest.startUpload();

Where have you added the request code?

• Activity
• Service
• Other class (add additional info about it)

Additional info

Basically the code in the Request code section above, called twice or more in a short time with the same file.

[gotev]

@hendrawd you have explained your scenario well even in the previous post. What I suggest you to do in your case is simply:

String uploadId = UUID.randomUUID().toString();

MultipartUploadRequest req = new MultipartUploadRequest(this, uploadId, url);

The id which you will get from:

String id = req.startUpload();

in this case is the same uploadId you have passed in the constructor, so you know the id even before the startUpload method invocation, because you generated it. Scenario like yours are exactly the reason why I’ve implemented also the constructor in which you can pass your own uploadId.

Some reference: MultipartUploadRequest constructor | startUpload method

[hendrawd]

Yes, i know. Sorry i wasn’t really clear from my last post. I edited your library to use notification action button #181 because of my requirement. The button just simply a cancel action.

I can create NotificationAction by:

NotificationAction actionCancel = new NotificationAction(R.drawable.ic_close, getString(R.string.notification_active_action_cancel_upload), UploadCanceller.getPendingIntent(this, uploadId));

Then i set it to NotificationConfig

private UploadNotificationConfig getNotificationConfig(String uploadId) {
    return new UploadNotificationConfig().addAction(actionCancel);//i set other configs too
}

Then i set it to MultipartUploadRequest

multipartUploadRequest.setNotificationConfig(getNotificationConfig(mCurrentPhotoPath));

I can’t get the id before i call

String idNeeded = multipartUploadRequest.startUpload();

But i must set the canceller with ID before call startUpload, that’s why i create the ID directly