Issues parsing variables after GQL upgrade to v5

Summary

I recently upgraded from v 4.6.0 to v 5.1.1 and ran into an issue where it’s not able to parse variables. Could you please tell me what I’ve forgotten or gotten wrong,

Old code

opts.Inputs = request?.Variables.ToInputs();

New code

opts.Variables = request?.Variables.ToInputs();

Relevant information

GQL request e.g.

query ($productID: String!) {
	productData(productId: $productID) {
		productId
                 title

Variables

{
    "productID": "12345", 
}

Errors,

errors": [
        {
            "message": "GraphQL.Validation.InvalidVariableError: Variable '$productID' is invalid. Unable to convert '4851605' to 'String'\n ---> System.InvalidOperationException: Unable to convert '12345' to the scalar type 'String'\n   at GraphQL.Types.ScalarGraphType.ThrowValueConversionError(Object value) in /_/src/GraphQL/Types/Scalars/ScalarGraphType.cs:line 235\n   at GraphQL.Types.StringGraphType.ParseValue(Object value) in /_/src/GraphQL/Types/Scalars/StringGraphType.cs:line 27\n   at GraphQL.Validation.ValidationContext.<GetVariableValue>g__ParseValueScalar|49_1(ScalarGraphType scalarGraphType, GraphQLVariableDefinition variableDef, VariableName variableName, Object value) in /_/src/GraphQL/Validation/ValidationContext.cs:line 249\n   --- End of inner exception stack trace ---\n   at GraphQL.Validation.ValidationContext.<GetVariableValue>g__ParseValueScalar|49_1(ScalarGraphType scalarGraphType, GraphQLVariableDefinition variableDef, VariableName variableName, Object value) in /_/src/GraphQL/Validation/ValidationContext.cs:line 253\n   at GraphQL.Validation.ValidationContext.<GetVariableValue>g__ParseValue|49_0(IGraphType type, GraphQLVariableDefinition variableDef, VariableName variableName, Object value, IVariableVisitor visitor) in /_/src/GraphQL/Validation/ValidationContext.cs:line 234\n   at GraphQL.Validation.ValidationContext.<GetVariableValue>g__ParseValue|49_0(IGraphType type, GraphQLVariableDefinition variableDef, VariableName variableName, Object value, IVariableVisitor visitor) in /_/src/GraphQL/Validation/ValidationContext.cs:line 224\n   at GraphQL.Validation.

Validation Rule

opts.ValidationRules = DocumentValidator.CoreRules.Concat(new[] { new InputValidationRule() });

Where InputValidationRules.cs is,

public class InputValidationRule : IValidationRule
    {
        public ValueTask<INodeVisitor> ValidateAsync(ValidationContext context)
        {
            return ValueTask.FromResult<INodeVisitor>(new NoopNodeVisitor());
        }

        private class NoopNodeVisitor : INodeVisitor
        {
            public void Enter(ASTNode node, ValidationContext context) { /* Noop */ }
            public void Leave(ASTNode node, ValidationContext context) { /* Noop */ }
        }
    }

I think the issue is either related to the way I’ve set the Variables or the InputValidationRule and I would be grateful to understand what to fix. Thank you!

[sungam3r]

@Shane32 Let’s change error message: $"Unable to convert '{value}' to '{scalarGraphType.Name}'" -> $"Unable to convert '{value}' of type {value.GetType().Name} to scalar '{scalarGraphType.Name}'"

Of course value may be null.

[sungam3r]

I’m not sure when we deprecated ObjectDictionaryConverter but we could probably write migration notes for that as well, assuming we removed it in v5.

I don’t know what to write exactly since I don’t remember. Write something if you feel that it’s necessary.