question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Broken minified build for graphiql 0.16.0

See original GitHub issue

Hi All,

The jsDelivr CDN distribution of GraphiQL seems broken at the moment.

I followed the official example at https://github.com/graphql/graphiql/blob/master/packages/examples/graphiql-cdn/index.html, and then changed the CDN URL from ./graphiql.js to https://cdn.jsdelivr.net/npm/graphiql/graphiql.min.js, which results in Minified React error #130.

Changing it to the full version ( https://cdn.jsdelivr.net/npm/graphiql/graphiql.js) seems to fix it.

Not sure if this issue belongs here, just something to note. Thanks!

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:8 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
acaocommented, Nov 26, 2019

https://unpkg.com/browse/graphiql@0.17.0/graphiql.min.js

0.17.0 minified build is now available. generated using webpack. re-creating it requires two pending and already well reviewed PRs to be merged, but it’s been thoroughly tested on chrome, firefox, safari.

an alpha probably would have been a better choice but some would argue 0.x.y versions are always prerelease.

either way, there you have it! please let me know if there are any regressions. i have not tested this new webpack generated minified build in IE11 yet, which is another issue. we are adding new maintainers now so we should be able to start getting more things merged.

also noting that 0.14.2 min.js was 1.15mb, and it’s now 744kb, so my math was wrong, but still a significant improvement! haha

1reaction
acaocommented, Nov 23, 2019

unfortunately we won’t have anyone to review PRs this weekend or for a while, so despite having a working minified bundle demo minified bundle it may still be a few weeks until a maintainer has the time to review this. But hey once it’s released it’ll be less than 1/4 of the original bundle size!

i spent a few nights just trying to get the legacy browserify build to work, but for whatever reason I couldn’t, so the only option was the full path forward with webpack (I had spiked with Rollup previously some months ago, and I just couldnt get the legacy umd global interface working right). Webpack is the most versatile tool for the job IMO.

I originally introduced it as a mega-PR but then tried to slice it into smaller chunks, so i broke the PR up into several. It wasn’t possible to break them down much further and still having building PRs. This is just unfortunately a chokepoint, given the complexity, so any peer review folks want to help with would be excellent and much appreciated, and would help my co-maintainers be able to review much more quickly.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Building error while deploying to AWS amplify - Stack Overflow
As the error says, "operation not supported on this platform", so there is a command that can't run on Linux, but it runs...
Read more >
Changelog - Cypress Documentation
The tsConfig build option is now respected for Angular component tests. ... We introduced several breaking changes to the Cypress configuration file ...
Read more >
package-lock.json · main · UBports / Infrastructure / devices.ubuntu ...
... "node_modules/@babel/helper-create-class-features-plugin": { "version": ... "fsevents 1 will break on node v14+ and could be using insecure binaries.
Read more >
Project dependencies - D2iQ Help Center
babel, helper-create-class-features-plugin, 7.17.9, MIT ... postcss-minify-gradients, 5.1.1, MIT. postcss-minify-params, 5.1.2 ... type-fest, 0.16.0, MIT.
Read more >
Module list for nightly-2022-05-05 :: Stackage Server
GraphQL.Monad.Class (graphql-client-1.1.1); Data.GraphQL.Query (graphql-client-1.1.1); Data. ... Build.Cabal (debian-build-0.10.2.1); Debian.Package.Build.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found