question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

History list doesn't render updates for labels and favorites

See original GitHub issue

Current Behavior

  1. List not updated on label change.
Given items in history list
When I change label of any item
Then list is not updated
  1. List not updated on favorites change.
Given items in history list
When I click the star icon on any item
Then list is not updated

Possible Solution

https://github.com/graphql/graphiql/blob/9f40b25a576c4e88588aadf7bf13b81fd470457d/src/components/QueryHistory.js#L121

https://github.com/graphql/graphiql/blob/9f40b25a576c4e88588aadf7bf13b81fd470457d/src/components/QueryHistory.js#L136

I think this is the intention:

 this.setState({ queries: [...this.historyStore.items, ...this.favoriteStore.items] });

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:6 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
wincentcommented, Apr 12, 2019

@nikitr: I left Facebook in July 2018, so I don’t really know anything about who’s working on what any more.

1reaction
wincentcommented, Apr 12, 2019

@nikitr: sorry but I don’t have merge privs on this repo any more.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Save favorite places in Maps on iPhone - Apple Support
In Maps on iPhone, add places to your favorites list for quick access. ... Rename the favorite: Double-tap the Label field, then enter...
Read more >
Google Maps Saved Places: How to Unleash its Full Potential
My only idea would be to figure out which place the offending photo is from, remove it so your list updates its image,...
Read more >
Address bar autocomplete suggestions in Firefox
How do I use the autocomplete list? Just start typing in the address bar. Suggestions from your browsing history, bookmarks, and tabs will...
Read more >
Common Microsoft Edge Problems, and How to Fix Them
Head over to the “…” button, choose Settings at the bottom of the list, select Privacy, Search, and Service, and then click Choose...
Read more >
Recently Updated Macro | Confluence Data Center and ...
Add the Recently Updated macro to a page to show a list of pages, blogs, files, and comments that have been created or...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found