question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

historyPaneOpen is not working properly

See original GitHub issue

When open and close the history panel, the flag historyPaneOpen does not respect the current visual state of it. The live demo has the same behaviour.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:1
  • Comments:5 (3 by maintainers)

github_iconTop GitHub Comments

1reaction
acaocommented, Sep 16, 2020

fix was released last week! enjoy! thanks @harshithpabbati !

0reactions
andreabreu-mecommented, Aug 24, 2020

@acao I’m on vacation too 😃

I think the problem its here: https://github.com/graphql/graphiql/blob/1.0.0/packages/graphiql/src/components/GraphiQL.tsx#L1273

Since setState is not synchronous, the value passed to the storage will always be the previous value.

This should fix the problem:

  handleToggleHistory = () => {
    if (typeof this.props.onToggleHistory === 'function') {
      this.props.onToggleHistory(!this.state.historyPaneOpen);
    }
    this._storage.set(
      'historyPaneOpen',
      JSON.stringify(!this.state.historyPaneOpen),
    );
    this.setState({ historyPaneOpen: !this.state.historyPaneOpen });
  };
Read more comments on GitHub >

github_iconTop Results From Across the Web

SQL Developer 3 EA1 - extremely slow - Oracle Communities
Hi, I am using SQL Developer 3 EA1 on a win Xp machine, in conjuction with Oracle 10gR2 and 11gR2 databases. I must...
Read more >
Manage Browser History in Microsoft Edge - Instructions
If desired, to pin the History pane open until you close it, click the “Pin history” button in the upper-right corner of the...
Read more >
History - Observable
With the history pane open, you can use the left and right arrows to browse ... When you publish a notebook, its history...
Read more >
NVIDIA CUDA - Manifold.net
GPU computations are often done on raster data, and Release 9 has dramatically greater capability to work with large raster data than Release...
Read more >
Last activity feed is not working properly - I found a Bug! - Report a ...
Last activity in the platform is not being shown in the homepage. To reproduce: - Check last item displayed in Activity feed -...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found